src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c ('K') | « src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h ('k') | src/trusted/validator_arm/ncvalidate.cc » ('j') | src/trusted/validator_x86/ncval_tests.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c

diff --git a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c

index c0de26738e9671ebe46478294d4117c7260cfacf..b841f9267358f9d4e2a99a8a115c0a1e6ba976f7 100644

--- a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c

+++ b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.c

@@ -153,9 +153,8 @@ static void NCJumpSummarizeDetailed(struct NCValidatorState* vstate) {

struct NCValidatorState *NCValidateInitDetailed(

const NaClPcAddress vbase,

const NaClMemorySize codesize,

- const uint8_t alignment,

const NaClCPUFeaturesX86* features) {

- struct NCValidatorState *vstate = NCValidateInit(vbase, codesize, alignment,

+ struct NCValidatorState *vstate = NCValidateInit(vbase, codesize,

FALSE, features);

if (NULL != vstate) {

vstate->summarize_fn = NCJumpSummarizeDetailed;