src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.c ('k') | src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c » ('j') | src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h

diff --git a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h

index 3f339efadafe390bfe27e8049177e9b046e671d1..f7a21a1cde418db884d855f541151109f96ed0a7 100644

--- a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h

+++ b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.h

@@ -21,7 +21,7 @@

* Basic usage:

* if (!NaClArchSuppported()) fail

- * vstate = NCValidateInit(base, size, 16, features);

+ * vstate = NCValidateInit(base, size, features);

* if vstate == 0 fail

* for each section:

* NCValidateSegment(maddr, base, size, vstate);

@@ -49,7 +49,6 @@ void NCValidateSetNumDiagnostics(struct NCValidatorState *vstate,

* Parameters:

* vbase: base virtual address for code segment

* codesize: size in bytes of code segment

- * alignment: 16 or 32, specifying alignment

* features: the features supported by the CPU that will run the code

* Returns:

* an initialized struct NCValidatorState * if everything is okay,

@@ -57,7 +56,6 @@ void NCValidateSetNumDiagnostics(struct NCValidatorState *vstate,

struct NCValidatorState *NCValidateInit(const NaClPcAddress vbase,

const NaClMemorySize codesize,

- const uint8_t alignment,

const int readonly_text,

const NaClCPUFeaturesX86 *features);

@@ -98,7 +96,7 @@ void NCValidateSegment(uint8_t *mbase, NaClPcAddress vbase,

* safely. Returns non-zero if successful.

int NCValidateSegmentPair(uint8_t *mbase_old, uint8_t *mbase_new,

- NaClPcAddress vbase, size_t sz, uint8_t alignment,

+ NaClPcAddress vbase, size_t sz,

const NaClCPUFeaturesX86 *features);

/* Check targets and alignment. Returns non-zero if there are */