src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c ('k') | src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.c » ('j') | src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h

diff --git a/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h b/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h

index 7528808cc5c16d12acf0b6b61099a3de4f8ed196..c9ed1e10090f3cad42cb1ddb18685b685dc7d1d8 100644

--- a/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h

+++ b/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_detailed.h

@@ -40,7 +40,7 @@

* if (!NaClArchSupported()) fail;

* NaClValidatorState* state =

- * NaClValidatorStateCreateDetailed(base, limit - base, 32, RegR15);

+ * NaClValidatorStateCreateDetailed(base, limit - base, RegR15, features);

* if (state == NULL) fail;

* for each section:

* NaClValidateSegment(maddr, vaddr, size, state);

@@ -63,7 +63,6 @@

* Parameters.

* vbase - The virtual address for the contents of the code segment.

* sz - The number of bytes in the code segment

- * alignment: 16 or 32, specifying alignment.

* base_register - OperandKind defining value for base register (or

* RegUnknown if not defined).

* features - The CPU features to use. Uses local features of machine if NULL.

@@ -74,7 +73,6 @@

NaClValidatorState* NaClValidatorStateCreateDetailed(

const NaClPcAddress vbase,

const NaClMemorySize sz,

- const uint8_t alignment,

const NaClOpKind base_register,

const NaClCPUFeaturesX86* features);