src/trusted/service_runtime/sel_validate_image.c - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/sel_validate_image.c

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/service_runtime/sel_validate_image.c

diff --git a/src/trusted/service_runtime/sel_validate_image.c b/src/trusted/service_runtime/sel_validate_image.c

index b9be9d4f7407555ed823bde8e8eb6eb0648b974b..1875ac1fe572aa87474d385ae73c5e5968472472 100644

--- a/src/trusted/service_runtime/sel_validate_image.c

+++ b/src/trusted/service_runtime/sel_validate_image.c

@@ -72,7 +72,6 @@ int NaClValidateCode(struct NaClApp *nap, uintptr_t guest_addr,

NACL_TARGET_SUBARCH)(

sb_kind,

guest_addr, data, size,

- nap->bundle_size,

TRUE, /* stub out */

FALSE, /* text is not read-only */

&nap->cpu_features,

@@ -86,7 +85,6 @@ int NaClValidateCode(struct NaClApp *nap, uintptr_t guest_addr,

NACL_TARGET_SUBARCH)(

sb_kind,

guest_addr, data, size,

- nap->bundle_size,

FALSE, /* do not stub out */

readonly_text,

&nap->cpu_features,

@@ -111,8 +109,7 @@ int NaClValidateCodeReplacement(struct NaClApp *nap, uintptr_t guest_addr,

NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement,

NACL_TARGET_ARCH,

NACL_TARGET_SUBARCH)

- (sb_kind, guest_addr, data_old, data_new, size, nap->bundle_size,

- &nap->cpu_features));

+ (sb_kind, guest_addr, data_old, data_new, size, &nap->cpu_features));

}

int NaClCopyCode(struct NaClApp *nap, uintptr_t guest_addr,

@@ -129,8 +126,7 @@ int NaClCopyCode(struct NaClApp *nap, uintptr_t guest_addr,

NACL_SUBARCH_NAME(ApplyValidatorCopy,

NACL_TARGET_ARCH,

NACL_TARGET_SUBARCH)

- (sb_kind, guest_addr, data_old, data_new, size, nap->bundle_size,

- &nap->cpu_features));

+ (sb_kind, guest_addr, data_old, data_new, size, &nap->cpu_features));

}

NaClErrorCode NaClValidateImage(struct NaClApp *nap) {

« no previous file with comments | « src/tools/validator_tools/ncstubout.c ('k') | src/trusted/validator/ncfileutil.h » ('j') | src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c » ('J')