Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/trusted/validator_arm/ncvalidate.cc

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/ncvalidate.cc
diff --git a/src/trusted/validator_arm/ncvalidate.cc b/src/trusted/validator_arm/ncvalidate.cc
index 6871b3f60b583c532eefdf86481cab57bf472dd3..b8e4f58009cbf511b111ebea08a69585f6a2533f 100644
--- a/src/trusted/validator_arm/ncvalidate.cc
+++ b/src/trusted/validator_arm/ncvalidate.cc
@@ -70,23 +70,22 @@ NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidator, arm, 32) (
uintptr_t guest_addr,
uint8_t *data,
size_t size,
- int bundle_size,
int stubout_mode,
int readonly_text,
const NaClCPUFeaturesArm *cpu_features,
struct NaClValidationCache *cache) {
- NaClValidationStatus status = NaClValidationFailedNotImplemented;
UNREFERENCED_PARAMETER(cpu_features);
UNREFERENCED_PARAMETER(sb_kind);
/* The ARM validator is currently unsafe w.r.t. caching. */
UNREFERENCED_PARAMETER(cache);
- if (stubout_mode) return NaClValidationFailedNotImplemented;
- if (readonly_text) return NaClValidationFailedNotImplemented;
- if (bundle_size == 16) {
- status = ((0 == NCValidateSegment(data, guest_addr, size))
- ? NaClValidationSucceeded : NaClValidationFailed);
- }
- return status;
+
+ if (stubout_mode)
+ return NaClValidationFailedNotImplemented;
+ if (readonly_text)
+ return NaClValidationFailedNotImplemented;
+
+ return ((0 == NCValidateSegment(data, guest_addr, size))
+ ? NaClValidationSucceeded : NaClValidationFailed);
}
NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32)
@@ -95,14 +94,12 @@ NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32)
uint8_t *data_old,
uint8_t *data_new,
size_t size,
- int bundle_size,
const NaClCPUFeaturesArm *cpu_features) {
UNREFERENCED_PARAMETER(sb_kind);
UNREFERENCED_PARAMETER(guest_addr);
UNREFERENCED_PARAMETER(data_old);
UNREFERENCED_PARAMETER(data_new);
UNREFERENCED_PARAMETER(size);
- UNREFERENCED_PARAMETER(bundle_size);
UNREFERENCED_PARAMETER(cpu_features);
return NaClValidationFailedNotImplemented;
}
@@ -113,14 +110,12 @@ NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCopy, arm, 32)
uint8_t *data_old,
uint8_t *data_new,
size_t size,
- int bundle_size,
const NaClCPUFeaturesArm *cpu_features) {
UNREFERENCED_PARAMETER(sb_kind);
UNREFERENCED_PARAMETER(guest_addr);
UNREFERENCED_PARAMETER(data_old);
UNREFERENCED_PARAMETER(data_new);
UNREFERENCED_PARAMETER(size);
- UNREFERENCED_PARAMETER(bundle_size);
UNREFERENCED_PARAMETER(cpu_features);
return NaClValidationFailedNotImplemented;
}

Powered by Google App Engine
This is Rietveld 408576698