Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h
diff --git a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h
index 16abb109346ace97ecbd23b2968eb7f031f62e86..890323ed913f24298d9a6323fd12fee059d8072e 100644
--- a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h
+++ b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_detailed.h
@@ -33,7 +33,7 @@
*
* Basic usage:
* if (!NaClArchSuppported()) fail
- * vstate = NCValidateInitDetailed(base, size, 16)
+ * vstate = NCValidateInitDetailed(base, size, cpu_features)
* if vstate == 0 fail
* for each section:
* NCValidateSegment(maddr, base, size, vstate);
@@ -57,7 +57,6 @@
* Parameters:
* vbase: base virtual address for code segment
* codesize: size in bytes of code segment
- * alignment: 16 or 32, specifying alignment
* features: the features supported by the CPU that will run the code
* Returns:
* an initialized struct NCValidatorState * if everything is okay,
@@ -66,7 +65,6 @@
struct NCValidatorState *NCValidateInitDetailed(
const NaClPcAddress vbase,
const NaClMemorySize codesize,
- const uint8_t alignment,
const NaClCPUFeaturesX86* features);
#endif /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_SEG_SFI_NCVALIDATE_DETAILED_H__ */

Powered by Google App Engine
This is Rietveld 408576698