src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/validator/x86/64/ncvalidate_verbose.c ('k') | src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c » ('j') | src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h

diff --git a/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h b/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h

index 6241d3e054f1d426a247d81622097ae2720d87f0..fd4cf4a54c4fe7b87de631d5dc69bab55c702496 100644

--- a/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h

+++ b/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h

@@ -97,7 +97,6 @@ typedef struct NaClValidatorState NaClValidatorState;

* Parameters.

* vbase - The virtual address for the contents of the code segment.

* sz - The number of bytes in the code segment.

- * alignment: 16 or 32, specifying alignment.

* base_register - OperandKind defining value for base register (or

* RegUnknown if not defined).

* readonly - Whether the text should be treated as read-only.

@@ -109,7 +108,6 @@ typedef struct NaClValidatorState NaClValidatorState;

NaClValidatorState* NaClValidatorStateCreate(

const NaClPcAddress vbase,

const NaClMemorySize codesize,

- const uint8_t alignment,

const NaClOpKind base_register,

const int readonly, /* Bool */

const NaClCPUFeaturesX86 *features);