src/trusted/validator_x86/testdata/32/test-1.nvals16 - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/32/test-1.nvals16

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator_x86/ncval_tests.c ('K') | « src/trusted/validator_x86/testdata/32/inst-crosses.nvals16 ('k') | src/trusted/validator_x86/testdata/32/test-11.nvals16 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 VALIDATOR: 80000006: Bad call alignment

2 VALIDATOR: 80000006: JUMP TARGET out of range

3 VALIDATOR: 8000000b: JUMP TARGET out of range

4 VALIDATOR: 80000010: Bad call alignment

5 VALIDATOR: 80000010: JUMP TARGET out of range

6 VALIDATOR: 80000016: ret instruction (not allowed)

7 VALIDATOR: 80000016: Illegal instruction

8 * <input> IS UNSAFE *

9

10 Opcode Histogram;

11 1 0x00 1 0x55 1 0x83 1 0x89

12 1 0xc3 1 0xc9 3 0xe8 1 0xf4

13 Analysis Summary:

14 10 Checked instructions

15 3 checked jump targets

16 0 calls/jumps need dynamic checking (0.00%)

17

18 Problems:

19 1 illegal instructions

20 3 bad jump targets

21 1 illegal unprotected indirect jumps (including ret)

22 2 instruction alignment defects

23 0 segmentation errors

24 0 bad prefix

25 0 bad instruction length

26 0 internal errors

OLD	NEW