Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: src/trusted/validator_arm/ncvalidate.cc

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Merge Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The Native Client Authors. All rights reserved. 2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 #include "native_client/src/trusted/validator_arm/ncvalidate.h" 7 #include "native_client/src/trusted/validator_arm/ncvalidate.h"
8 8
9 9
10 #include <vector> 10 #include <vector>
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 bool success = validator.validate(segments, &sink); 63 bool success = validator.validate(segments, &sink);
64 if (!success) return 2; // for compatibility with old validator 64 if (!success) return 2; // for compatibility with old validator
65 return 0; 65 return 0;
66 } 66 }
67 67
68 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidator, arm, 32) ( 68 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidator, arm, 32) (
69 enum NaClSBKind sb_kind, 69 enum NaClSBKind sb_kind,
70 uintptr_t guest_addr, 70 uintptr_t guest_addr,
71 uint8_t *data, 71 uint8_t *data,
72 size_t size, 72 size_t size,
73 int bundle_size,
74 int stubout_mode, 73 int stubout_mode,
75 int readonly_text, 74 int readonly_text,
76 const NaClCPUFeaturesArm *cpu_features, 75 const NaClCPUFeaturesArm *cpu_features,
77 struct NaClValidationCache *cache) { 76 struct NaClValidationCache *cache) {
78 NaClValidationStatus status = NaClValidationFailedNotImplemented;
79 UNREFERENCED_PARAMETER(cpu_features); 77 UNREFERENCED_PARAMETER(cpu_features);
80 UNREFERENCED_PARAMETER(sb_kind); 78 UNREFERENCED_PARAMETER(sb_kind);
81 /* The ARM validator is currently unsafe w.r.t. caching. */ 79 /* The ARM validator is currently unsafe w.r.t. caching. */
82 UNREFERENCED_PARAMETER(cache); 80 UNREFERENCED_PARAMETER(cache);
83 if (stubout_mode) return NaClValidationFailedNotImplemented; 81
84 if (readonly_text) return NaClValidationFailedNotImplemented; 82 if (stubout_mode)
85 if (bundle_size == 16) { 83 return NaClValidationFailedNotImplemented;
86 status = ((0 == NCValidateSegment(data, guest_addr, size)) 84 if (readonly_text)
87 ? NaClValidationSucceeded : NaClValidationFailed); 85 return NaClValidationFailedNotImplemented;
88 } 86
89 return status; 87 return ((0 == NCValidateSegment(data, guest_addr, size))
88 ? NaClValidationSucceeded : NaClValidationFailed);
90 } 89 }
91 90
92 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32) 91 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32)
93 (enum NaClSBKind sb_kind, 92 (enum NaClSBKind sb_kind,
94 uintptr_t guest_addr, 93 uintptr_t guest_addr,
95 uint8_t *data_old, 94 uint8_t *data_old,
96 uint8_t *data_new, 95 uint8_t *data_new,
97 size_t size, 96 size_t size,
98 int bundle_size,
99 const NaClCPUFeaturesArm *cpu_features) { 97 const NaClCPUFeaturesArm *cpu_features) {
100 UNREFERENCED_PARAMETER(sb_kind); 98 UNREFERENCED_PARAMETER(sb_kind);
101 UNREFERENCED_PARAMETER(guest_addr); 99 UNREFERENCED_PARAMETER(guest_addr);
102 UNREFERENCED_PARAMETER(data_old); 100 UNREFERENCED_PARAMETER(data_old);
103 UNREFERENCED_PARAMETER(data_new); 101 UNREFERENCED_PARAMETER(data_new);
104 UNREFERENCED_PARAMETER(size); 102 UNREFERENCED_PARAMETER(size);
105 UNREFERENCED_PARAMETER(bundle_size);
106 UNREFERENCED_PARAMETER(cpu_features); 103 UNREFERENCED_PARAMETER(cpu_features);
107 return NaClValidationFailedNotImplemented; 104 return NaClValidationFailedNotImplemented;
108 } 105 }
109 106
110 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCopy, arm, 32) 107 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCopy, arm, 32)
111 (enum NaClSBKind sb_kind, 108 (enum NaClSBKind sb_kind,
112 uintptr_t guest_addr, 109 uintptr_t guest_addr,
113 uint8_t *data_old, 110 uint8_t *data_old,
114 uint8_t *data_new, 111 uint8_t *data_new,
115 size_t size, 112 size_t size,
116 int bundle_size,
117 const NaClCPUFeaturesArm *cpu_features) { 113 const NaClCPUFeaturesArm *cpu_features) {
118 UNREFERENCED_PARAMETER(sb_kind); 114 UNREFERENCED_PARAMETER(sb_kind);
119 UNREFERENCED_PARAMETER(guest_addr); 115 UNREFERENCED_PARAMETER(guest_addr);
120 UNREFERENCED_PARAMETER(data_old); 116 UNREFERENCED_PARAMETER(data_old);
121 UNREFERENCED_PARAMETER(data_new); 117 UNREFERENCED_PARAMETER(data_new);
122 UNREFERENCED_PARAMETER(size); 118 UNREFERENCED_PARAMETER(size);
123 UNREFERENCED_PARAMETER(bundle_size);
124 UNREFERENCED_PARAMETER(cpu_features); 119 UNREFERENCED_PARAMETER(cpu_features);
125 return NaClValidationFailedNotImplemented; 120 return NaClValidationFailedNotImplemented;
126 } 121 }
127 122
128 EXTERN_C_END 123 EXTERN_C_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698