Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 10116003: Add #ifdefs to separate NaCl and non-NaCl PPAPI Proxy code. (Closed)

Created:
8 years, 8 months ago by bbudge
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add #ifdefs to separate NaCl and non-NaCl PPAPI Proxy code. This CL moves non-NaCl interface proxies like Flash, and also temporarily moves unported interfaces such as Graphics3D. BUG=116317 TEST=builds without PPAPI link errors Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132817

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -548 lines) Patch
M ppapi/ppapi_proxy_untrusted.gyp View 7 chunks +28 lines, -29 lines 0 comments Download
M ppapi/proxy/interface_list.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/proxy/interface_list.cc View 8 chunks +12 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 17 chunks +198 lines, -189 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 5 chunks +120 lines, -120 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.cc View 3 chunks +4 lines, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 5 chunks +38 lines, -35 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 9 chunks +113 lines, -119 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 4 chunks +20 lines, -14 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 5 chunks +38 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bbudge
I tried to keep the number of #ifdef-#endif blocks to a minimum by moving things. ...
8 years, 8 months ago (2012-04-17 21:59:11 UTC) #1
brettw
lgtm
8 years, 8 months ago (2012-04-17 22:55:32 UTC) #2
dmichael (off chromium)
8 years, 8 months ago (2012-04-18 15:37:15 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698