Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 10115053: Assign ids to incoming arguments (to be used in checked mode). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 6717)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1795,14 +1795,15 @@
void CodeGenerator::GenerateArgumentTypeChecks() {
const Function& function = parsed_function_.function();
- LocalScope* scope = parsed_function_.node_sequence()->scope();
+ const SequenceNode& sequence_node = *parsed_function_.node_sequence();
+ LocalScope* scope = sequence_node.scope();
const int num_fixed_params = function.num_fixed_parameters();
const int num_opt_params = function.num_optional_parameters();
ASSERT(num_fixed_params + num_opt_params <= scope->num_variables());
- for (int i = 0; i < num_fixed_params + num_opt_params; i++) {
+ for (intptr_t i = 0; i < num_fixed_params + num_opt_params; i++) {
LocalVariable* parameter = scope->VariableAt(i);
GenerateLoadVariable(EAX, *parameter);
- GenerateAssertAssignable(AstNode::kNoId,
+ GenerateAssertAssignable(sequence_node.ParameterIdAt(i),
parameter->token_index(),
NULL,
parameter->type(),

Powered by Google App Engine
This is Rietveld 408576698