Assign ids to incoming arguments (to be used in checked mode).

Assign ids to incoming arguments (to be used in checked mode).
Committed: https://code.google.com/p/dart/source/detail?r=6718

[regis, 2012-04-18 23:59:13]

LGTM

https://chromiumcodereview.appspot.com/10115053/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10115053/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:129: node_sequence_->set_last_parameter_id(parameter_id);
It is strange to call set_last_parameter_id, but not set_first_parameter_id,
when the function has no parameters.
How about storing the number of parameters instead of the last_parameter_id? But
isn't that number available without storing it?

[srdjan, 2012-04-19 00:04:20]

https://chromiumcodereview.appspot.com/10115053/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10115053/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:129: node_sequence_->set_last_parameter_id(parameter_id);
On 2012/04/18 23:59:13, regis wrote:
> It is strange to call set_last_parameter_id, but not set_first_parameter_id,
> when the function has no parameters.
> How about storing the number of parameters instead of the last_parameter_id?
But
> isn't that number available without storing it? 

Discussed off-line: last parameter id is set to kNoId (initial value of
parameter_id) if function has not parameters.