Issue 10115048: Fix single process mode in content_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10115048: Fix single process mode in content_shell. (Closed)

Created:
8 years, 8 months ago by jam

Modified:
8 years, 8 months ago

Reviewers:
ojan

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix single process mode in content_shell. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132907

Patch Set 1 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -9 lines)			Patch
M	chrome/app/chrome_main_delegate.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/browser_main_runner.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/shell/shell_main_delegate.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

there's another issue with the pak file that comes up when visiting google and webkit ...

8 years, 8 months ago (2012-04-18 23:43:06 UTC) #1

jam

(to be clear, the other issue isn't related to single process)

8 years, 8 months ago (2012-04-18 23:43:17 UTC) #2

ojan

8 years, 8 months ago (2012-04-18 23:45:36 UTC) #3

LGTM

On Wed, Apr 18, 2012 at 4:43 PM, <jam@chromium.org> wrote:

> (to be clear, the other issue isn't related to single process)
>
>
>
http://codereview.chromium.**org/10115048/<http://codereview.chromium.org/101...
>

Expand Messages | Collapse Messages