Add a missing arity check for top-level methods in Dart_Invoke.

vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
@@ skipping 3179 matching lines @@
       "}\n";
 
   // Shared setup.
   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   Dart_Handle cls = Dart_GetClass(lib, Dart_NewString("Methods"));
   EXPECT_VALID(cls);
   Dart_Handle instance = Dart_Invoke(lib, Dart_NewString("test"), 0, NULL);
   EXPECT_VALID(instance);
   Dart_Handle args[1];
   args[0] = Dart_NewString("!!!");
+  Dart_Handle bad_args[2];
+  bad_args[0] = Dart_NewString("bad1");
+  bad_args[1] = Dart_NewString("bad2");
   Dart_Handle result;
   Dart_Handle name;
   const char* str;
 
   // Instance method.
   name = Dart_NewString("instanceMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   result = Dart_Invoke(instance, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("instance !!!", str);
 
+  // Instance method, wrong arg count.
+  EXPECT_ERROR(Dart_Invoke(instance, name, 2, bad_args),
+               "did not find instance method 'Methods.instanceMethod'");
+
   // Hidden instance method.
   name = Dart_NewString("_instanceMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   result = Dart_Invoke(instance, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("hidden instance !!!", str);
 
   // Inherited method.
   name = Dart_NewString("inheritedMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   result = Dart_Invoke(instance, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("inherited !!!", str);
 
   // Static method.
   name = Dart_NewString("staticMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(instance, name, 1, args)));
   result = Dart_Invoke(cls, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("static !!!", str);
 
+  // Static method, wrong arg count.
+  EXPECT_ERROR(Dart_Invoke(cls, name, 2, bad_args),
+               "did not find static method 'Methods.staticMethod'");
+
   // Hidden static method.
   name = Dart_NewString("_staticMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(instance, name, 1, args)));
   result = Dart_Invoke(cls, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("hidden static !!!", str);
 
   // Static non-inherited method.  Not found at any level.
   name = Dart_NewString("non_inheritedMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(instance, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
 
   // Top-Level method.
   name = Dart_NewString("topMethod");
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(instance, name, 1, args)));
   result = Dart_Invoke(lib, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("top !!!", str);
 
+  // Top-level method, wrong arg count.
+  EXPECT_ERROR(Dart_Invoke(lib, name, 2, bad_args),
+               "did not find top-level function 'topMethod'");
+
   // Hidden top-level method.
   name = Dart_NewString("_topMethod");
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(instance, name, 1, args)));
   result = Dart_Invoke(lib, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("hidden top !!!", str);
 }
 
@@ skipping 1682 matching lines @@
   EXPECT_VALID(result);
   EXPECT(Dart_IsDouble(result));
   double out;
   result = Dart_DoubleValue(result, &out);
   fprintf(stderr, "Benchmark_UseDartApi: %f us per iteration\n", out);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart