lib/compiler/implementation/ssa/codegen.dart - Issue 10115026: Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10115026: Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/resolver.dart ('K') | « lib/compiler/implementation/resolver.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | lib/compiler/implementation/typechecker.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/codegen.dart

diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart

index 80b33d877bd0d91a9b482af6b36236578973d5fa..4514dbe5b8016152dd707b56786d009194bd69d3 100644

--- a/lib/compiler/implementation/ssa/codegen.dart

+++ b/lib/compiler/implementation/ssa/codegen.dart

@@ -1621,12 +1621,12 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

}

void visitIs(HIs node) {

- Type type = node.typeName;

+ Type type = node.typeExpression;

Element element = type.element;

if (element.kind === ElementKind.TYPE_VARIABLE) {

- compiler.unimplemented("visitIs for type variables");

+ compiler.unimplemented("visitIs for type variables", instruction: node);

} else if (element.kind === ElementKind.TYPEDEF) {

- compiler.unimplemented("visitIs for typedefs");

+ compiler.unimplemented("visitIs for typedefs", instruction: node);

}

compiler.registerIsCheck(element);

LibraryElement coreLibrary = compiler.coreLibrary;