Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: lib/compiler/implementation/typechecker.dart

Issue 10115026: Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/typechecker.dart
diff --git a/lib/compiler/implementation/typechecker.dart b/lib/compiler/implementation/typechecker.dart
index effa903e1d089269798ddf6a7cca36d807db718e..c98e4140d8668e56c1a7feba08ff984c4d5b4dcd 100644
--- a/lib/compiler/implementation/typechecker.dart
+++ b/lib/compiler/implementation/typechecker.dart
@@ -61,19 +61,20 @@ class StatementType implements Type {
}
class InterfaceType implements Type {
- final SourceString name;
final Element element;
final Link<Type> arguments;
- const InterfaceType(this.name, this.element,
+ const InterfaceType(this.element,
[this.arguments = const EmptyLink<Type>()]);
+ SourceString get name() => element.name;
+
toString() {
StringBuffer sb = new StringBuffer();
sb.add(name.slowToString());
if (!arguments.isEmpty()) {
sb.add('<');
- arguments.printOn(sb);
+ arguments.printOn(sb, ', ');
sb.add('>');
}
return sb.toString();
@@ -118,8 +119,8 @@ class Types {
// TODO(karlklose): should we have a class Void?
Types.with(Element dynamicElement, LibraryElement library)
- : voidType = new InterfaceType(VOID, new ClassElement(VOID, library)),
- dynamicType = new InterfaceType(DYNAMIC, dynamicElement);
+ : voidType = new InterfaceType(new ClassElement(VOID, library)),
+ dynamicType = new InterfaceType(dynamicElement);
Type lookup(SourceString s) {
if (VOID == s) {
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698