lib/compiler/implementation/compile_time_constants.dart - Issue 10115026: Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10115026: Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/compile_time_constants.dart

diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart

index c035a937b1c8aa508ef51281d1735a71360dc21a..8b9dafcf095cad599ddc51ece3e76801c2f062a6 100644

--- a/lib/compiler/implementation/compile_time_constants.dart

+++ b/lib/compiler/implementation/compile_time_constants.dart

@@ -775,7 +775,7 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {

ClassElement classElement = compiler.jsHelperLibrary.find(className);

classElement.ensureResolved(compiler);

// TODO(floitsch): copy over the generic type.

- Type type = new InterfaceType(classElement.name, classElement);

+ Type type = new InterfaceType(classElement);

compiler.registerInstantiatedClass(classElement);

Constant constant = new MapConstant(type, keysList, values, protoValue);

compiler.constantHandler.registerCompileTimeConstant(constant);

« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »