Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: lib/compiler/implementation/ssa/tracer.dart

Issue 10115026: Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('tracer'); 5 #library('tracer');
6 6
7 #import('dart:io'); 7 #import('dart:io');
8 #import('ssa.dart'); 8 #import('ssa.dart');
9 #import('../leg.dart'); 9 #import('../leg.dart');
10 10
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 // The last input is the guarded expression. 424 // The last input is the guarded expression.
425 for (int i = 0; i < inputs.length - 1; i++) { 425 for (int i = 0; i < inputs.length - 1; i++) {
426 envBuffer.add(" ${temporaryId(inputs[i])}"); 426 envBuffer.add(" ${temporaryId(inputs[i])}");
427 } 427 }
428 String on = node.isOn ? "on" : "off"; 428 String on = node.isOn ? "on" : "off";
429 String id = temporaryId(node.guarded); 429 String id = temporaryId(node.guarded);
430 return "TypeGuard($on): $id is $type env: $envBuffer"; 430 return "TypeGuard($on): $id is $type env: $envBuffer";
431 } 431 }
432 432
433 String visitIs(HIs node) { 433 String visitIs(HIs node) {
434 String type = node.typeName.toString(); 434 String type = node.typeExpression.toString();
435 return "TypeTest: ${temporaryId(node.expression)} is $type"; 435 return "TypeTest: ${temporaryId(node.expression)} is $type";
436 } 436 }
437 } 437 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698