Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: vm/stub_code_ia32.cc

Issue 10114012: Some minor cleanup. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/stub_code_ia32.cc
===================================================================
--- vm/stub_code_ia32.cc (revision 6666)
+++ vm/stub_code_ia32.cc (working copy)
@@ -1513,7 +1513,7 @@
// Generate inline cache check for 'num_args'.
// ECX: Inline cache data object.
-// EDX: Arguments array.
+// EDX: Arguments descriptor array.
// TOS(0): return address
// Control flow:
// - If receiver is null -> jump to IC miss.
@@ -1544,7 +1544,8 @@
}
ASSERT(num_args > 0);
- // Get receiver.
+ // Get receiver (first read number of arguments from argument descriptor array
+ // and then access the receiver from the stack).
__ movl(EAX, FieldAddress(EDX, Array::data_offset()));
__ movl(EAX, Address(ESP, EAX, TIMES_2, 0)); // EAX (argument_count) is Smi.
@@ -1613,14 +1614,14 @@
}
__ Bind(&ic_miss);
- // Get receiver, again.
+ // Compute address of arguments (first read number of arguments from argument
+ // descriptor array and then compute address on the stack).
__ movl(EAX, FieldAddress(EDX, Array::data_offset()));
__ leal(EAX, Address(ESP, EAX, TIMES_2, 0)); // EAX is Smi.
__ EnterFrame(0);
__ pushl(EDX); // Preserve arguments array.
__ pushl(ECX); // Preserve IC data array
__ pushl(raw_null); // Setup space on stack for result (target code object).
- __ movl(EDX, FieldAddress(EDX, Array::data_offset()));
// Push call arguments.
for (intptr_t i = 0; i < num_args; i++) {
__ movl(EDX, Address(EAX, -kWordSize * i));
« no previous file with comments | « no previous file | vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698