Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011393004: Fast NTP support for themes, dark themes, favicons. (Closed)

Created:
5 years, 9 months ago by fserb
Modified:
5 years, 9 months ago
Reviewers:
*Mathieu, *huangs
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fast NTP support for themes, dark themes, favicons. BUG=461032 Committed: https://crrev.com/ecef7e57576665aa2b9b6002f08c47a6443ae5ac Cr-Commit-Position: refs/heads/master@{#321791}

Patch Set 1 #

Total comments: 12

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -25 lines) Patch
M chrome/browser/resources/local_ntp/local_ntp_fast.css View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp_fast.js View 1 5 chunks +18 lines, -17 lines 2 comments Download
M chrome/browser/resources/local_ntp/most_visited_single.css View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_single.html View 1 1 chunk +6 lines, -2 lines 1 comment Download
M chrome/browser/resources/local_ntp/most_visited_single.js View 1 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
fserb
5 years, 9 months ago (2015-03-18 20:43:47 UTC) #3
huangs
Sorry for the delay. LGTM with nit; wouldn't mind looking again if you ask. https://chromiumcodereview.appspot.com/1011393004/diff/1/chrome/browser/resources/local_ntp/local_ntp_fast.js ...
5 years, 9 months ago (2015-03-19 19:13:13 UTC) #4
fserb
Done. thanks. https://codereview.chromium.org/1011393004/diff/1/chrome/browser/resources/local_ntp/local_ntp_fast.js File chrome/browser/resources/local_ntp/local_ntp_fast.js (right): https://codereview.chromium.org/1011393004/diff/1/chrome/browser/resources/local_ntp/local_ntp_fast.js#newcode190 chrome/browser/resources/local_ntp/local_ntp_fast.js:190: var titleColor = null; On 2015/03/19 19:13:13, ...
5 years, 9 months ago (2015-03-19 20:02:53 UTC) #5
huangs
More comments. https://chromiumcodereview.appspot.com/1011393004/diff/20001/chrome/browser/resources/local_ntp/local_ntp_fast.js File chrome/browser/resources/local_ntp/local_ntp_fast.js (right): https://chromiumcodereview.appspot.com/1011393004/diff/20001/chrome/browser/resources/local_ntp/local_ntp_fast.js#newcode244 chrome/browser/resources/local_ntp/local_ntp_fast.js:244: titleColor = convertToRRGGBBAAColor(info.textColorRgba); Sorry should have caught ...
5 years, 9 months ago (2015-03-19 23:45:01 UTC) #6
Mathieu
lgtm
5 years, 9 months ago (2015-03-23 15:58:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011393004/20001
5 years, 9 months ago (2015-03-23 16:01:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 16:52:28 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ecef7e57576665aa2b9b6002f08c47a6443ae5ac Cr-Commit-Position: refs/heads/master@{#321791}
5 years, 9 months ago (2015-03-23 16:53:17 UTC) #12
huangs
5 years, 9 months ago (2015-03-24 03:23:56 UTC) #13
Message was sent while issue was closed. 
You didn't address my comments.  :(  I'll have to do a patch.

Powered by Google App Engine
This is Rietveld 408576698