Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: base/android/dalvik_heap_size.cc

Issue 10113009: Set Android/V8 memory limits from dalvik.vm.heapsize. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove redundant includes Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/dalvik_heap_size.cc
diff --git a/base/android/dalvik_heap_size.cc b/base/android/dalvik_heap_size.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ef0c5bbbc151b76c283775c34c08780116616a27
--- /dev/null
+++ b/base/android/dalvik_heap_size.cc
@@ -0,0 +1,57 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/android/dalvik_heap_size.h"
+
+#include <sys/system_properties.h>
+
Xianzhu 2012/05/15 21:10:25 Should include "base/logging.h" for CHECK and DCHE
ulan 2012/05/16 09:25:52 Added "base/logging.h" and removed "base/memory/si
+#include "base/memory/singleton.h"
+#include "base/string_number_conversions.h"
+
+namespace base {
+namespace android{
Xianzhu 2012/05/15 21:10:25 Nit: space before '{'
ulan 2012/05/16 09:25:52 Done.
+
+DalvikHeapSize::DalvikHeapSize() : heap_size_mb_(0) {
+ char heap_size_str[PROP_VALUE_MAX];
+ __system_property_get("dalvik.vm.heapsize", heap_size_str);
+ heap_size_mb_ = ParseHeapSize(std::string(heap_size_str));
+}
+
+DalvikHeapSize::~DalvikHeapSize() {}
+
+int DalvikHeapSize::HeapSizeMB() const {
+ return heap_size_mb_;
+}
+
+int DalvikHeapSize::ParseHeapSize(const std::string& str) const {
+ const int64 KB = 1024;
+ const int64 MB = 1024 * KB;
+ const int64 GB = 1024 * MB;
+ CHECK_GT(str.size(), 0u);
+ int64 factor = 1;
+ size_t length = str.size();
+ if (str[length - 1] == 'k') {
+ factor = KB;
+ length--;
+ } else if (str[length - 1] == 'm') {
+ factor = MB;
+ length--;
+ } else if (str[length - 1] == 'g') {
+ factor = GB;
+ length--;
+ } else {
+ CHECK('0' <= str[length - 1] && str[length - 1] <= '9');
+ }
+ int64 result = 0;
+ bool parsed = base::StringToInt64(str.substr(0, length), &result);
+ CHECK(parsed);
+ result = result * factor / MB;
+ // dalvik.vm.heapsize property is writable by user,
+ // truncate it to reasonable value to avoid overflows later.
+ result = std::min<int64>(std::max<int64>(32, result), 1024);
+ return static_cast<int>(result);
+}
+
+} // namespace android
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698