Remove EPM:all_hosts_ and use all_extension_views_ instead.

chrome/browser/automation/automation_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_util.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/automation/automation_provider.h"
 #include "chrome/browser/automation/automation_provider_json.h"
-#include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/restore_tab_helper.h"
 #include "chrome/browser/sessions/session_id.h"
 #include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/automation_id.h"
 #include "chrome/common/chrome_view_type.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/render_view_host_delegate.h"
 #include "content/public/browser/web_contents.h"
 #include "net/cookies/cookie_monster.h"
 #include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 
 using content::BrowserThread;
 using content::RenderViewHost;
 using content::WebContents;
 
@@ skipping 361 matching lines @@
   }
   return active;
 }
 
 AutomationId GetIdForTab(const TabContentsWrapper* tab) {
   return AutomationId(
       AutomationId::kTypeTab,
       base::IntToString(tab->restore_tab_helper()->session_id().id()));
 }
 
-AutomationId GetIdForExtensionView(const ExtensionHost* ext_host) {
+AutomationId GetIdForExtensionView(
+    const content::RenderViewHost* render_view_host) {
   AutomationId::Type type;
-  switch (ext_host->extension_host_type()) {
+  switch (render_view_host->GetDelegate()->GetRenderViewType()) {
     case chrome::VIEW_TYPE_EXTENSION_POPUP:
       type = AutomationId::kTypeExtensionPopup;
       break;
     case chrome::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
       type = AutomationId::kTypeExtensionBgPage;
       break;
     case chrome::VIEW_TYPE_EXTENSION_INFOBAR:
       type = AutomationId::kTypeExtensionInfobar;
       break;
     default:
       type = AutomationId::kTypeInvalid;
       break;
   }
   // Since these extension views do not permit navigation, using the
   // renderer process and view ID should suffice.
   std::string id = base::StringPrintf("%d|%d",
-      ext_host->render_view_host()->GetRoutingID(),
-      ext_host->render_process_host()->GetID());
+      render_view_host->GetRoutingID(),
+      render_view_host->GetProcess()->GetID());
   return AutomationId(type, id);
 }
 
 AutomationId GetIdForExtension(const Extension* extension) {
   return AutomationId(AutomationId::kTypeExtension, extension->id());
 }
 
 bool GetTabForId(const AutomationId& id, WebContents** tab) {
   if (id.type() != AutomationId::kTypeTab)
     return false;
@@ skipping 28 matching lines @@
 }
 
 namespace {
 
 bool GetExtensionRenderViewForId(
     const AutomationId& id,
     Profile* profile,
     RenderViewHost** rvh) {
   ExtensionProcessManager* extension_mgr =
       profile->GetExtensionProcessManager();
-  ExtensionProcessManager::const_iterator iter;
-  for (iter = extension_mgr->begin(); iter != extension_mgr->end();
+  const ExtensionProcessManager::ContentsSet contents_set =
+      extension_mgr->GetAllContents();
+  for (ExtensionProcessManager::ContentsSet::const_iterator iter =
+           contents_set.begin(); iter != contents_set.end();
        ++iter) {
-    ExtensionHost* host = *iter;
+    content::WebContents* contents = *iter;
+    RenderViewHost* host = contents->GetRenderViewHost();

[Charlie Reis, 2012/04/19 21:42:10]

We need to be very careful here.  GetRenderViewHost returns the *current*
RenderViewHost for a WebContents, which changes over time as the tab navigates. 
Are we certain this WebContents hasn't navigated and stopped showing an
extension?

[Aaron Boodman, 2012/04/20 01:00:55]

Good point. My bad, I forgot that WebContents encapsulated navigation.

     AutomationId this_id = GetIdForExtensionView(host);
     if (id == this_id) {
-      *rvh = host->render_view_host();
+      *rvh = host;
       return true;
     }
   }
   return false;
 }
 
 }  // namespace
 
 bool GetRenderViewForId(
     const AutomationId& id,
@@ skipping 49 matching lines @@
       const Extension* extension;
       return GetExtensionForId(id, profile, &extension);
     }
     default:
       break;
   }
   return false;
 }
 
 }  // namespace automation_util