Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 10108017: Prevent dragging in open/save dialogs. (Closed)

Created:
8 years, 8 months ago by SeRya
Modified:
8 years, 8 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Prevent dragging in open/save dialogs. Files in open and save dialogs are draggable (with no effect). Fixing it. BUG=None TEST=Manual test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_transfer_controller.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
SeRya
8 years, 8 months ago (2012-04-17 14:26:34 UTC) #1
Vladislav Kaznacheev
lgtm
8 years, 8 months ago (2012-04-17 14:29:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10108017/1
8 years, 8 months ago (2012-04-17 14:56:17 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 14:56:21 UTC) #4
Presubmit check for 10108017-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/file_manager/js/file_transfer_controller.js:
  line 40: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 51: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 62: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 81: E0001: Extra space after "directories"
    var directories  = [];
                   ^^
  line 79: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 108: E0217: Missing @return JsDoc in function with non-trivial return
   */
   ^^
  line 108: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^
  line 346: E0225: Missing @this JsDoc in function referencing "this". (this
usually means you are trying to reference "this" in a static function, or you
have forgotten to mark a constructor with @constructor)
   */
   ^^

Presubmit checks took 1.1s to calculate.

Powered by Google App Engine
This is Rietveld 408576698