Another case of creating from factory constructors was not taken into account in r6619

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index 7b4860b0abbfb00326664250df27d471f1284454..27c912662af082602da749cb34cde975224f9bd8 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -416,8 +416,9 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
   }
 
   /**
-   * Factory constructor can instantiate any class and return it non-abstract class instance, but
-   * spec requires warnings, so we provide it, but using different constant.
+   * Factory constructor can instantiate any class and return it non-abstract class instance, Even
+   * thought this is an abstract class, there should be no warnings for the invocation of the
+   * factory constructor.
    */
   public void test_abstractClass_whenInstantiate_factoryConstructor()
       throws Exception {
@@ -425,14 +426,14 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
         analyzeLibrary(
             getName(),
             makeCode(
-                "abstract class A {",
+                "abstract class A {",  // explicitly abstract
                 "  factory A() {",
                 "    return null;",
                 "  }",
                 "}",
                 "class C {",
                 "  foo() {",
-                "    return new A();",
+                "    return new A();",  // no error - factory constructor
                 "  }",
                 "}"));
     assertErrors(
@@ -440,6 +441,35 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
   }
 
   /**
+   * Factory constructor can instantiate any class and return it non-abstract class instance, Even
+   * thought this is an abstract class, there should be no warnings for the invocation of the
+   * factory constructor.
+   */
+  public void test_abstractClass_whenInstantiate_factoryConstructor2()
+      throws Exception {
+    AnalyzeLibraryResult libraryResult =
+        analyzeLibrary(
+            getName(),
+            makeCode(
+                "class A extends B {",  // class doesn't implement all abstract methods
+                "  factory A() {",
+                "    return null;",
+                "  }",
+                "}",
+                "class B {",
+                "  abstract method();",
+                "}",
+                "class C {",
+                "  foo() {",
+                "    return new A();",  // no error, factory constructor

[ahe, 2012/04/17 11:44:55]

Actually, this should never cause a warning. This is because the spec was
changed after I implemented the original algorithm for abstract.

This is definition from the spec:

"An abstract class is either a class that is explicitly declared with the
abstract modifier, or a class that declares at least one abstract method
(7.1.1)."

So A is not an abstract class.

However, then the idea was that we would warn about classes that have
unimplemented methods but not marked abstract. But I can't find this part in the
spec.

[zundel, 2012/04/17 13:49:17]

Since I know the invoking factory method warning is an issue, I committed as is
and added issue http://code.google.com/p/dart/issues/detail?id=2619

This could be a 'value added' warning. But, I've seen it come out in what might
be seen as a nuisance warning in some contexts.  We need to get a story on being
able to turn individual warnings on and off.


On 2012/04/17 11:44:55, ahe wrote:

+                "  }",
+                "}"));
+    assertErrors(
+        libraryResult.getTypeErrors(),
+        errEx(TypeErrorCode.ABSTRACT_CLASS_WITHOUT_ABSTRACT_MODIFIER, 1, 7, 1));
+  }
+
+  /**
    * Spec 7.3 It is a static warning if a setter declares a return type other than void.
    */
   public void testWarnOnNonVoidSetter() throws Exception {