Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 10108007: Font Settings Extension API: Rename get/setFontName to get/setFont. (Closed)

Created:
8 years, 8 months ago by falken
Modified:
8 years, 8 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Font Settings Extension API: Rename get/setFontName to get/setFont. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -145 lines) Patch
M chrome/browser/extensions/extension_font_settings_api.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/experimental.fontSettings.json View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/popup.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.fontSettings.html View 8 chunks +108 lines, -108 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/static/experimental.fontSettings.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/font_settings/test.js View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
falken
This is just a renaming change (discussed in http://codereview.chromium.org/10008076/), so I plan to TBR this.
8 years, 8 months ago (2012-04-17 01:51:30 UTC) #1
Matt Perry
8 years, 8 months ago (2012-04-17 01:52:44 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698