[Icons NTP] Working prototype to fetch, store, and display big icons.

chrome/common/favicon/fallback_icon_url_parser_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/favicon/fallback_icon_url_parser.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "components/favicon_base/fallback_icon_style.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkColor.h"
@@ skipping 195 matching lines @@
   }
 }
 
 TEST_F(FallbackIconUrlParserTest, ParseFallbackIconPathSuccess) {
   const std::string specs = "31,black,fff,0.75,0.25";
 
   // Everything populated.
   {
     chrome::ParsedFallbackIconPath parsed;
     EXPECT_TRUE(parsed.Parse(specs + "/" + kTestUrlStr));
-    EXPECT_EQ(GURL(kTestUrlStr), parsed.url());
     EXPECT_EQ(31, parsed.size_in_pixels());
     const favicon_base::FallbackIconStyle& style = parsed.style();
     EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
     EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color);
     EXPECT_EQ(0.75, style.font_size_ratio);
     EXPECT_EQ(0.25, style.roundness);
+    EXPECT_EQ(GURL(kTestUrlStr), GURL(parsed.url_string()));
+    EXPECT_EQ(specs.length() + 1, parsed.path_index());
   }
 
   // Empty URL.
   {
     chrome::ParsedFallbackIconPath parsed;
     EXPECT_TRUE(parsed.Parse(specs + "/"));
-    EXPECT_EQ(GURL(), parsed.url());
     EXPECT_EQ(31, parsed.size_in_pixels());
     const favicon_base::FallbackIconStyle& style = parsed.style();
     EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
     EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color);
     EXPECT_EQ(0.75, style.font_size_ratio);
     EXPECT_EQ(0.25, style.roundness);
+    EXPECT_EQ(GURL(), GURL(parsed.url_string()));
+    EXPECT_EQ(specs.length() + 1, parsed.path_index());
+  }
+
+  // Tolerate invalid URL.
+  {
+    chrome::ParsedFallbackIconPath parsed;
+    EXPECT_TRUE(parsed.Parse(specs + "/NOT A VALID URL"));
+    EXPECT_EQ(31, parsed.size_in_pixels());
+    const favicon_base::FallbackIconStyle& style = parsed.style();
+    EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
+    EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color);
+    EXPECT_EQ(0.75, style.font_size_ratio);
+    EXPECT_EQ(0.25, style.roundness);
+    EXPECT_EQ("NOT A VALID URL", parsed.url_string());
+    EXPECT_EQ(specs.length() + 1, parsed.path_index());
   }
 
   // Size and style are default.
   {
+    std::string specs2 = ",,,,";
     chrome::ParsedFallbackIconPath parsed;
-    EXPECT_TRUE(parsed.Parse(std::string(",,,,/") + kTestUrlStr));
-    EXPECT_EQ(GURL(kTestUrlStr), parsed.url());
+    EXPECT_TRUE(parsed.Parse(specs2 + "/" + kTestUrlStr));
     EXPECT_EQ(gfx::kFaviconSize, parsed.size_in_pixels());
     const favicon_base::FallbackIconStyle& style = parsed.style();
     EXPECT_EQ(kDefaultBackgroundColor, style.background_color);
     EXPECT_EQ(kDefaultTextColorLight, style.text_color);
     EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio);
     EXPECT_EQ(kDefaultRoundness, style.roundness);
+    EXPECT_EQ(GURL(kTestUrlStr), GURL(parsed.url_string()));
+    EXPECT_EQ(specs2.length() + 1, parsed.path_index());
   }
 }
 
 TEST_F(FallbackIconUrlParserTest, ParseFallbackIconPathFailure) {
   const char* test_cases[] = {
     // Bad size.
     "-1,000,fff,0.75,0.25/http://www.google.com/",
     // Bad specs.
     "32,#junk,fff,0.75,0.25/http://www.google.com/",
-    // Bad URL.
-    "32,000,fff,0.75,0.25/NOT A VALID URL",
   };
   for (size_t i = 0; i < arraysize(test_cases); ++i) {
     chrome::ParsedFallbackIconPath parsed;
     EXPECT_FALSE(parsed.Parse(test_cases[i])) << "test_cases[" << i << "]";
   }
 }
 
 }  // namespace chrome