Issue 10107020: [filemanager] New visuals for file name, saved and overwrite original UI elemetns in image editor.

Issue 10107020: [filemanager] New visuals for file name, saved and overwrite original UI elemetns in image editor. (Closed)

Created:
8 years, 8 months ago by dgozman

Modified:
8 years, 8 months ago

Reviewers:
Vladislav Kaznacheev, Dmitry Zvorygin

CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] New visuals for file name, saved and overwrite original UI elemetns in image editor. BUG=chromium-os:29303, chromium-os:29305, chromium-os:28471 TEST=See bugs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132789

Patch Set 1 #

Patch Set 2 : Image added. #

Patch Set 3 : Style. #

Total comments: 2

Patch Set 4 : Review fix. #

Patch Set 5 : Bubble #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -63 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 2 3 4	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/css/common.css	View	1 2 3 4	2 chunks	+56 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/gallery.css	View	1 2 3 4	1 chunk	+84 lines, -30 lines	0 comments	Download
M	chrome/browser/resources/file_manager/gallery.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/common/bubble_point_white.png	View	1 2 3 4	Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/common/checkbox_white_checked.png	View	1 2 3 4	Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/common/checkbox_white_unchecked.png	View	1 2 3 4	Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/images/common/close_x_gray.png	View	1 2 3 4	Binary file		0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View	1 2 3 4	12 chunks	+96 lines, -28 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Dmitry Zvorygin

https://chromiumcodereview.appspot.com/10107020/diff/4001/chrome/browser/resources/file_manager/css/common.css File chrome/browser/resources/file_manager/css/common.css (right): https://chromiumcodereview.appspot.com/10107020/diff/4001/chrome/browser/resources/file_manager/css/common.css#newcode32 chrome/browser/resources/file_manager/css/common.css:32: input.common[type='checkbox'][white]:checked::after { I'd prefer styles to attributes here.

8 years, 8 months ago (2012-04-17 15:25:09 UTC) #2

dgozman

PTAL https://chromiumcodereview.appspot.com/10107020/diff/4001/chrome/browser/resources/file_manager/css/common.css File chrome/browser/resources/file_manager/css/common.css (right): https://chromiumcodereview.appspot.com/10107020/diff/4001/chrome/browser/resources/file_manager/css/common.css#newcode32 chrome/browser/resources/file_manager/css/common.css:32: input.common[type='checkbox'][white]:checked::after { On 2012/04/17 15:25:09, Dmitry Zvorygin wrote: ...

8 years, 8 months ago (2012-04-17 16:05:30 UTC) #3

Dmitry Zvorygin

On 2012/04/17 16:05:30, dgozman wrote: > PTAL > > https://chromiumcodereview.appspot.com/10107020/diff/4001/chrome/browser/resources/file_manager/css/common.css > File chrome/browser/resources/file_manager/css/common.css (right): > ...

8 years, 8 months ago (2012-04-17 16:17:51 UTC) #4

lgtm

Expand Messages | Collapse Messages