Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10107016: Reduce blinking of icons in the preview panel. (Closed)

Created:
8 years, 8 months ago by SeRya
Modified:
8 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Reduce blinking of icons in the preview panel. BUG=chromium-os:29248 TEST=Manual test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132572

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 4

Patch Set 3 : Fix #

Total comments: 2

Patch Set 4 : Comment added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 3 chunks +34 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
SeRya
8 years, 8 months ago (2012-04-17 13:20:28 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/10107016/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10107016/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2303 chrome/browser/resources/file_manager/js/file_manager.js:2303: imageLoadCalback.bind(box)); imageLoadCallback.bind(null, box) https://chromiumcodereview.appspot.com/10107016/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2335 chrome/browser/resources/file_manager/js/file_manager.js:2335: forcedShowTimeout = setTimeout(showThumbnails, 100); ...
8 years, 8 months ago (2012-04-17 13:33:43 UTC) #2
SeRya
https://chromiumcodereview.appspot.com/10107016/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10107016/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2303 chrome/browser/resources/file_manager/js/file_manager.js:2303: imageLoadCalback.bind(box)); On 2012/04/17 13:33:43, dgozman wrote: > imageLoadCallback.bind(null, box) ...
8 years, 8 months ago (2012-04-17 13:51:31 UTC) #3
dgozman
LGTM https://chromiumcodereview.appspot.com/10107016/diff/5001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10107016/diff/5001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2268 chrome/browser/resources/file_manager/js/file_manager.js:2268: if (self.selection == selection) { Comment this line ...
8 years, 8 months ago (2012-04-17 14:07:44 UTC) #4
SeRya
8 years, 8 months ago (2012-04-17 14:12:32 UTC) #5 
https://chromiumcodereview.appspot.com/10107016/diff/5001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10107016/diff/5001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2268: if
(self.selection == selection) {
On 2012/04/17 14:07:44, dgozman wrote:
> Comment this line please.

Done.

Powered by Google App Engine
This is Rietveld 408576698