Issue 10107009: Revert 132479 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA en…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10107009: Revert 132479 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA en… (Closed)

Created:
8 years, 8 months ago by sky

Modified:
8 years, 8 months ago

Reviewers:
SteveT

CC:
chromium-reviews, darin-cc_chromium.org, MAD, Ilya Sherman, jar (doing other things), cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 132479 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA enabled. BUG=123609 TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Also, ensure that unit_tests GoogleUtilTests all pass. Review URL: http://codereview.chromium.org/10054029 TBR=stevet@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132488

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -106 lines)			Patch
M	chrome/browser/google/google_util.h	View	1 chunk	+2 lines, -14 lines	0 comments	Download
M	chrome/browser/google/google_util.cc	View	3 chunks	+12 lines, -16 lines	0 comments	Download
M	chrome/browser/google/google_util_unittest.cc	View	2 chunks	+0 lines, -35 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/net/chrome_network_delegate.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/net/chrome_network_delegate.cc	View	3 chunks	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/protector/protector_service.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_prepopulate_data.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

SteveT

8 years, 8 months ago (2012-04-17 02:03:56 UTC) #2

lgtm

Thanks for reverting. Sorry I was away for this - was in transit at the time,
methinks.