Revert 132455 - Abort sync cycles when download step fails

sync/test/engine/mock_connection_manager.h

Index: sync/test/engine/mock_connection_manager.h
===================================================================
--- sync/test/engine/mock_connection_manager.h	(revision 132475)
+++ sync/test/engine/mock_connection_manager.h	(working copy)
@@ -117,8 +117,7 @@
   // issue multiple requests during a sync cycle.
   void NextUpdateBatch();
 
-  void FailNextPostBufferToPathCall() { countdown_to_postbuffer_fail_ = 1; }
-  void FailNthPostBufferToPathCall(int n) { countdown_to_postbuffer_fail_ = n; }
+  void FailNextPostBufferToPathCall() { fail_next_postbuffer_ = true; }
 
   void SetClearUserDataResponseStatus(sync_pb::SyncEnums::ErrorType errortype);
 
@@ -223,11 +222,6 @@
     return store_birthday_;
   }
 
-  // Explicitly indicate that we will not be fetching some updates.
-  void ClearUpdatesQueue() {
-    update_queue_.clear();
-  }
-
   // Locate the most recent update message for purpose of alteration.
   sync_pb::SyncEntity* GetMutableLastUpdate();
 
@@ -305,9 +299,8 @@
   bool client_stuck_;
   std::string commit_time_rename_prepended_string_;
 
-  // On each PostBufferToPath() call, we decrement this counter.  The call fails
-  // iff we hit zero at that call.
-  int countdown_to_postbuffer_fail_;
+  // Fail on the next call to PostBufferToPath().
+  bool fail_next_postbuffer_;
 
   // Our directory.  Used only to ensure that we are not holding the transaction
   // lock when performing network I/O.  Can be NULL if the test author is