Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 10106017: Allow read access on a root directory of IsolatedFileSystem (Closed)

Created:
8 years, 8 months ago by kinuko
Modified:
8 years, 7 months ago
Reviewers:
ericu, tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam
Visibility:
Public.

Description

Allow read access on a root directory of IsolatedFileSystem Since r124366 we started checking file permission against ChildProcessSecurityPolicy on each operation but the current code prohibits read access on a root directory of IsolatedFileSystem, since the root directory in IsolatedFileSystem is purely virtual and has no associated platform path (to check the permission). BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M content/browser/fileapi/fileapi_message_filter.cc View 2 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
(Gush I haven't published this...) Can you take a look?Thanks! Additional note: why we may ...
8 years, 7 months ago (2012-05-18 07:03:02 UTC) #1
tzik
lgtm
8 years, 7 months ago (2012-05-18 07:21:20 UTC) #2
ericu
8 years, 7 months ago (2012-05-21 21:36:29 UTC) #3
LGTM.

Calling copyTo on the root would then create a new directory containing all the
root contents?  That seems perfectly reasonable.

Example:

dragging /isolated/id/foo/bar, /isolated/id/foo/bas, /isolated/id/bling
isolated_root.copyTo(/temporary/hoge)

Now you have:

/temporary/hoge/foo/bar
/temporary/hoge/foo/bas
/temporary/hoge/bling

Powered by Google App Engine
This is Rietveld 408576698