Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tests/language/src/ListDoubleIndexInLoop2Test.dart

Issue 10106004: Revert "Refactor type propagation." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language-leg.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/src/ListDoubleIndexInLoop2Test.dart
diff --git a/tests/language/src/ListDoubleIndexInLoop2Test.dart b/tests/language/src/ListDoubleIndexInLoop2Test.dart
deleted file mode 100644
index 2a0ebd7acc8371342c556b89a32e7bc403092e67..0000000000000000000000000000000000000000
--- a/tests/language/src/ListDoubleIndexInLoop2Test.dart
+++ /dev/null
@@ -1,33 +0,0 @@
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-// Dart test program for testing arrays.
-
-bar() => true;
-
-tata() => 1.5;
-
-// The type propagation in Dart2Js wrongly took the intersection of all incoming
-// types in a loop-phi. In this case the back-edge brought type 'number' which,
-// combined with 'integer' (i = 0) was narrowed to 'integer'. As a result no
-// check was inserted for the list access.
-foo(a) {
- var i;
- if (bar()) {
- // t's desired type is conflicting. Once it is used as array receiver. And
- // once as integer. The backward propagation thus can't decide.
- // The forward declaration, however, will assign type num.
- var t = 0 + tata();
- i = t;
- if (!bar()) t[0];
- } else {
- i = 0;
- }
- // The phi, combining the two 'i's must reach the conclusion that i is of
- // type num and therefore needs a check before accessing the array.
- a[i];
-}
-
-main() {
- Expect.throws(() => foo([1, 2]));
-}
« no previous file with comments | « tests/language/language-leg.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698