Replace string copy code and scoped_arrays() with const_casts in MediaDeviceNotificationsLinuxTest.

Replace string copy code and scoped_arrays() with const_casts in MediaDeviceNotificationsLinuxTest. Explain why this is safe.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133814

[vandebo (ex-Chrome), 2012-04-18 00:01:50]

LGTM

https://chromiumcodereview.appspot.com/10105037/diff/3001/chrome/browser/medi...
File chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc
(right):

https://chromiumcodereview.appspot.com/10105037/diff/3001/chrome/browser/medi...
chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc:189:
// mtnent struct has several char* fields, even though we do not write to
nit: we -> it

https://chromiumcodereview.appspot.com/10105037/diff/3001/chrome/browser/medi...
chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc:194:
// fields in question, it will crash if it tries to wrote to the mnt_opts
nit: wrote -> write

[Lei Zhang, 2012-04-18 03:40:05]

On 2012/04/18 00:01:50, vandebo wrote:
> LGTM
> 
>
https://chromiumcodereview.appspot.com/10105037/diff/3001/chrome/browser/medi...
> File chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc
> (right):
> 
>
https://chromiumcodereview.appspot.com/10105037/diff/3001/chrome/browser/medi...
> chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc:189:
> // mtnent struct has several char* fields, even though we do not write to
> nit: we -> it
> 
>
https://chromiumcodereview.appspot.com/10105037/diff/3001/chrome/browser/medi...
> chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc:194:
> // fields in question, it will crash if it tries to wrote to the mnt_opts
> nit: wrote -> write

I rewrote the paragraph a bit and just noted that an addmntent() implementation
that does the wrong thing will likely cause a crash or failure. Trying to
detecting such a condition will be more complicated  than the code we are trying
to get rid of.

[commit-bot: I haz the power, 2012-04-24 22:13:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10105037/6002

[commit-bot: I haz the power, 2012-04-25 00:00:27]

Change committed as 133814