Issue 10105025: Fix fast array literals to ignore prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10105025: Fix fast array literals to ignore prototype chain. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix fast array literals to ignore prototype chain. This makes sure that boilerplate objects for array literals with non-constant elements (which will contain the hole at non-constant positions) will not cause prototype chain lookups when generating optimized code. R=erik.corry@gmail.com BUG=chromium:123512 TEST=mjsunit/regress/regress-123512 Committed: https://code.google.com/p/v8/source/detail?r=11350

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Erik Corry. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -5 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-123512.js	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM https://chromiumcodereview.appspot.com/10105025/diff/1/test/mjsunit/regress/regress-123512.js File test/mjsunit/regress/regress-123512.js (right): https://chromiumcodereview.appspot.com/10105025/diff/1/test/mjsunit/regress/regress-123512.js#newcode52 test/mjsunit/regress/regress-123512.js:52: %DeoptimizeFunction(f); Can we test the same for object ...

8 years, 8 months ago (2012-04-17 10:35:37 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-17 10:59:52 UTC) #3

Added new patch set.

https://chromiumcodereview.appspot.com/10105025/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-123512.js (right):

https://chromiumcodereview.appspot.com/10105025/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-123512.js:52: %DeoptimizeFunction(f);
On 2012/04/17 10:35:37, Erik Corry wrote:
> Can we test the same for object literals as we do for Array literals?

Done (for both properties and elements on object literals).

Expand Messages | Collapse Messages