Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3534)

Unified Diff: chrome/browser/extensions/extension_sorting.h

Issue 10105019: Merge 132468 - [NTP4] Fix empty apps page crash. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1084/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_sorting.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_sorting.h
===================================================================
--- chrome/browser/extensions/extension_sorting.h (revision 132527)
+++ chrome/browser/extensions/extension_sorting.h (working copy)
@@ -93,7 +93,7 @@
// Converts the page index integer to its StringOrdinal equivalent. This takes
// O(# of apps) worst-case.
- StringOrdinal PageIntegerAsStringOrdinal(size_t page_index) const;
+ StringOrdinal PageIntegerAsStringOrdinal(size_t page_index);
private:
// Unit tests.
@@ -129,6 +129,9 @@
const StringOrdinal& page_ordinal,
const StringOrdinal& app_launch_ordinal);
+ // Ensures |ntp_ordinal_map_| is of |minimum_size| number of entries.
+ void CreateOrdinalsIfNecessary(size_t minimum_size);
+
// Removes the mapping for |extension_id| with a page ordinal of
// |page_ordinal| and a app launch ordinal of |app_launch_ordinal|. If there
// is not matching map, nothing happens. This works with valid and invalid
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_sorting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698