Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10105011: Adding pyauto test: browser still function after browser crash (Closed)

Created:
8 years, 8 months ago by tturchetto
Modified:
8 years, 8 months ago
Reviewers:
Nirnimesh
CC:
krisr, chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Adding pyauto test: browser still function after browser crash BUG=chromium-os:27964 TEST=This is a test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133537

Patch Set 1 : Modified copyright to 2012 #

Total comments: 4

Patch Set 2 : Used non-live url #

Patch Set 3 : Changed Copyright year #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/test/functional/chromeos_browser.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tturchetto
8 years, 8 months ago (2012-04-16 22:16:19 UTC) #1
Nirnimesh
https://chromiumcodereview.appspot.com/10105011/diff/3/chrome/test/functional/chromeos_browser.py File chrome/test/functional/chromeos_browser.py (right): https://chromiumcodereview.appspot.com/10105011/diff/3/chrome/test/functional/chromeos_browser.py#newcode47 chrome/test/functional/chromeos_browser.py:47: self.NavigateToURL('http://www.google.com') I don't think this call will succeed. The ...
8 years, 8 months ago (2012-04-18 23:21:54 UTC) #2
tturchetto
http://codereview.chromium.org/10105011/diff/3/chrome/test/functional/chromeos_browser.py File chrome/test/functional/chromeos_browser.py (right): http://codereview.chromium.org/10105011/diff/3/chrome/test/functional/chromeos_browser.py#newcode47 chrome/test/functional/chromeos_browser.py:47: self.NavigateToURL('http://www.google.com') On 2012/04/18 23:21:54, Nirnimesh wrote: > I don't ...
8 years, 8 months ago (2012-04-23 21:29:39 UTC) #3
Nirnimesh
LGTM, if the test works.
8 years, 8 months ago (2012-04-23 21:40:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tturchetto@chromium.org/10105011/11001
8 years, 8 months ago (2012-04-23 21:42:38 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/test/functional/chromeos_browser.py. While running patch -p1 --forward --force; patching file chrome/test/functional/chromeos_browser.py ...
8 years, 8 months ago (2012-04-23 21:42:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tturchetto@chromium.org/10105011/11001
8 years, 8 months ago (2012-04-23 22:05:39 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 22:05:40 UTC) #8
Can't apply patch for file chrome/test/functional/chromeos_browser.py.
While running patch -p1 --forward --force;
patching file chrome/test/functional/chromeos_browser.py
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 25 (offset -14 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/test/functional/chromeos_browser.py.rej

Powered by Google App Engine
This is Rietveld 408576698