Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: content/common/sandbox_init_linux.cc

Issue 10105009: Apply an initial seccomp filter policy for Pepper Flash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/ppapi_plugin_process_host.cc ('k') | content/ppapi_plugin/ppapi_plugin_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_init_linux.cc
===================================================================
--- content/common/sandbox_init_linux.cc (revision 132266)
+++ content/common/sandbox_init_linux.cc (working copy)
@@ -194,6 +194,57 @@
EmitFailSyscall(__NR_access, ENOENT, program);
}
+static void ApplyFlashPolicy(std::vector<struct sock_filter>* program) {
+ // "Hot" syscalls go first.
+ EmitAllowSyscall(__NR_futex, program);
+ EmitAllowSyscall(__NR_write, program);
+ EmitAllowSyscall(__NR_epoll_wait, program);
+ EmitAllowSyscall(__NR_read, program);
+ EmitAllowSyscall(__NR_times, program);
+
+ // Less hot syscalls.
+ EmitAllowSyscall(__NR_clone, program);
+ EmitAllowSyscall(__NR_set_robust_list, program);
+ EmitAllowSyscall(__NR_getuid, program);
+ EmitAllowSyscall(__NR_geteuid, program);
+ EmitAllowSyscall(__NR_getgid, program);
+ EmitAllowSyscall(__NR_getegid, program);
+ EmitAllowSyscall(__NR_epoll_create, program);
+ EmitAllowSyscall(__NR_fcntl, program);
+ EmitAllowSyscall(__NR_socketpair, program);
+ EmitAllowSyscall(__NR_pipe, program);
+ EmitAllowSyscall(__NR_epoll_ctl, program);
+ EmitAllowSyscall(__NR_gettid, program);
+ EmitAllowSyscall(__NR_prctl, program);
+ EmitAllowSyscall(__NR_fstat, program);
+ EmitAllowSyscall(__NR_sendmsg, program);
+ EmitAllowSyscall(__NR_mmap, program);
+ EmitAllowSyscall(__NR_munmap, program);
+ EmitAllowSyscall(__NR_mprotect, program);
+ EmitAllowSyscall(__NR_madvise, program);
+ EmitAllowSyscall(__NR_rt_sigaction, program);
+ EmitAllowSyscall(__NR_rt_sigprocmask, program);
+ EmitAllowSyscall(__NR_wait4, program);
+ EmitAllowSyscall(__NR_exit_group, program);
+ EmitAllowSyscall(__NR_exit, program);
+ EmitAllowSyscall(__NR_rt_sigreturn, program);
+ EmitAllowSyscall(__NR_restart_syscall, program);
+ EmitAllowSyscall(__NR_close, program);
+ EmitAllowSyscall(__NR_recvmsg, program);
+ EmitAllowSyscall(__NR_lseek, program);
+ EmitAllowSyscall(__NR_brk, program);
+ EmitAllowSyscall(__NR_sched_yield, program);
+
+ // These are under investigation, and hopefully not here for the long term.
+ EmitAllowSyscall(__NR_shmctl, program);
+ EmitAllowSyscall(__NR_shmat, program);
+ EmitAllowSyscall(__NR_shmdt, program);
+
+ EmitFailSyscall(__NR_open, ENOENT, program);
+ EmitFailSyscall(__NR_execve, ENOENT, program);
+ EmitFailSyscall(__NR_access, ENOENT, program);
+}
+
static bool CanUseSeccompFilters() {
int ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, 0, 0, 0);
if (ret != 0 && errno == EFAULT)
@@ -219,7 +270,8 @@
void InitializeSandbox() {
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
- if (command_line.HasSwitch(switches::kNoSandbox))
+ if (command_line.HasSwitch(switches::kNoSandbox) ||
+ command_line.HasSwitch(switches::kDisableSeccompFilterSandbox))
return;
std::string process_type =
@@ -238,6 +290,8 @@
if (process_type == switches::kGpuProcess) {
ApplyGPUPolicy(&program);
+ } else if (process_type == switches::kPpapiPluginProcess) {
+ ApplyFlashPolicy(&program);
} else {
NOTREACHED();
}
« no previous file with comments | « content/browser/ppapi_plugin_process_host.cc ('k') | content/ppapi_plugin/ppapi_plugin_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698