Chromium Code Reviews
Help | Chromium Project | Sign in
(654)

Issue 10105002: Enable HTTP pipelining field trial on dev channel for 10% of users. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by James Simonsen
Modified:
2 years ago
Reviewers:
cbentzel, willchan, mmenke
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Enable HTTP pipelining field trial on dev channel for 10% of users.


BUG=110794
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132444

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Lint Patch
M chrome/browser/net/http_pipelining_compatibility_client.cc View 1 chunk +2 lines, -0 lines 2 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 5
James Simonsen
I just want to make sure the server can handle the traffic, then I'll bump ...
2 years ago #1
willchan
LGTM On Mon, Apr 16, 2012 at 11:48 AM, <simonjam@chromium.org> wrote: > Reviewers: Matt Menke, ...
2 years ago #2
cbentzel
https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc File chrome/browser/net/http_pipelining_compatibility_client.cc (right): https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc#newcode473 chrome/browser/net/http_pipelining_compatibility_client.cc:473: kTrialName, kDivisor, "disable_test", 2012, 4, 21, NULL); Are you ...
2 years ago #3
James Simonsen
https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc File chrome/browser/net/http_pipelining_compatibility_client.cc (right): https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc#newcode473 chrome/browser/net/http_pipelining_compatibility_client.cc:473: kTrialName, kDivisor, "disable_test", 2012, 4, 21, NULL); On 2012/04/16 ...
2 years ago #4
cbentzel
2 years ago #5
LGTM

On Mon, Apr 16, 2012 at 3:05 PM, <simonjam@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/10105002/diff/1/**
>
chrome/browser/net/http_**pipelining_compatibility_**client.cc<https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc>
> File chrome/browser/net/http_**pipelining_compatibility_**client.cc
> (right):
>
> https://chromiumcodereview.**appspot.com/10105002/diff/1/**
>
chrome/browser/net/http_**pipelining_compatibility_**client.cc#newcode473<https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc#newcode473>
> chrome/browser/net/http_**pipelining_compatibility_**client.cc:473:
> kTrialName, kDivisor, "disable_test", 2012, 4, 21, NULL);
> On 2012/04/16 18:52:24, cbentzel wrote:
>
>> Are you going to want to bump this up as well?
>>
>
> I think I'll wait until I bump it up to 100%, just to err on the side of
> paranoia. This is the first time it'll be on dev channel. If all is
> well, I'll extend it and go to 100% later this week.
>
>
https://chromiumcodereview.**appspot.com/10105002/<https://chromiumcodereview...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6