Enable HTTP pipelining field trial on dev channel for 10% of users.

Enable HTTP pipelining field trial on dev channel for 10% of users.


BUG=110794
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132444

[James Simonsen, 2012-04-16 18:48:04]

I just want to make sure the server can handle the traffic, then I'll bump it up
to 100%.

[willchan no longer on Chromium, 2012-04-16 18:50:03]

LGTM

On Mon, Apr 16, 2012 at 11:48 AM, <simonjam@chromium.org> wrote:

> Reviewers: Matt Menke, willchan, cbentzel,
>
> Message:
> I just want to make sure the server can handle the traffic, then I'll bump
> it up
> to 100%.
>
> Description:
> Enable HTTP pipelining field trial on dev channel for 10% of users.
>
>
> BUG=110794
> TEST=None
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10105002/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/net/http_**pipelining_compatibility_**client.cc
>
>
> Index: chrome/browser/net/http_**pipelining_compatibility_**client.cc
> diff --git a/chrome/browser/net/http_**pipelining_compatibility_**client.cc
> b/chrome/browser/net/http_**pipelining_compatibility_**client.cc
> index 5a179890f453292d5a85e83e4c3922**b68cff1365..**
> 1fc294fb3750dafc2ac10ad2cff159**d805b50908 100644
> --- a/chrome/browser/net/http_**pipelining_compatibility_**client.cc
> +++ b/chrome/browser/net/http_**pipelining_compatibility_**client.cc
> @@ -475,6 +475,8 @@ void CollectPipeliningCapabilitySta**tsOnIOThread(
>   chrome::VersionInfo::Channel channel = chrome::VersionInfo::**
> GetChannel();
>   if (channel == chrome::VersionInfo::CHANNEL_**CANARY) {
>     probability_to_run_test = 100;
> +  } else if (channel == chrome::VersionInfo::CHANNEL_**DEV) {
> +    probability_to_run_test = 10;
>   }
>
>   int collect_stats_group = trial->AppendGroup("enable_**test",
>
>
>

[cbentzel, 2012-04-16 18:52:24]

https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/htt...
File chrome/browser/net/http_pipelining_compatibility_client.cc (right):

https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/htt...
chrome/browser/net/http_pipelining_compatibility_client.cc:473: kTrialName,
kDivisor, "disable_test", 2012, 4, 21, NULL);
Are you going to want to bump this up as well?

[James Simonsen, 2012-04-16 19:05:29]

https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/htt...
File chrome/browser/net/http_pipelining_compatibility_client.cc (right):

https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/htt...
chrome/browser/net/http_pipelining_compatibility_client.cc:473: kTrialName,
kDivisor, "disable_test", 2012, 4, 21, NULL);
On 2012/04/16 18:52:24, cbentzel wrote:
> Are you going to want to bump this up as well?

I think I'll wait until I bump it up to 100%, just to err on the side of
paranoia. This is the first time it'll be on dev channel. If all is well, I'll
extend it and go to 100% later this week.

[cbentzel, 2012-04-16 19:30:58]

LGTM

On Mon, Apr 16, 2012 at 3:05 PM, <simonjam@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/10105002/diff/1/**
>
chrome/browser/net/http_**pipelining_compatibility_**client.cc<https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc>
> File chrome/browser/net/http_**pipelining_compatibility_**client.cc
> (right):
>
> https://chromiumcodereview.**appspot.com/10105002/diff/1/**
>
chrome/browser/net/http_**pipelining_compatibility_**client.cc#newcode473<https://chromiumcodereview.appspot.com/10105002/diff/1/chrome/browser/net/http_pipelining_compatibility_client.cc#newcode473>
> chrome/browser/net/http_**pipelining_compatibility_**client.cc:473:
> kTrialName, kDivisor, "disable_test", 2012, 4, 21, NULL);
> On 2012/04/16 18:52:24, cbentzel wrote:
>
>> Are you going to want to bump this up as well?
>>
>
> I think I'll wait until I bump it up to 100%, just to err on the side of
> paranoia. This is the first time it'll be on dev channel. If all is
> well, I'll extend it and go to 100% later this week.
>
>
https://chromiumcodereview.**appspot.com/10105002/<https://chromiumcodereview...
>