Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: Source/modules/mediastream/RTCPeerConnection.idl

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test case crash. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCPeerConnection.idl
diff --git a/Source/modules/mediastream/RTCPeerConnection.idl b/Source/modules/mediastream/RTCPeerConnection.idl
index fa5494606e720f8f19b2043bc0492e96f623dd77..f0e5a07a5727027a208ee989685b24dc08168c1f 100644
--- a/Source/modules/mediastream/RTCPeerConnection.idl
+++ b/Source/modules/mediastream/RTCPeerConnection.idl
@@ -35,16 +35,18 @@
ConstructorCallWith=ExecutionContext,
NoInterfaceObject,
RaisesException=Constructor,
+ SetWrapperReferenceTo(RTCSessionDescription localDescription,
+ RTCSessionDescription remoteDescription)
] interface RTCPeerConnection : EventTarget {
[RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);
[RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);
[RaisesException] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
- [RaisesException=Getter] readonly attribute RTCSessionDescription localDescription;
+ readonly attribute RTCSessionDescription localDescription;
[RaisesException] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
- [RaisesException=Getter] readonly attribute RTCSessionDescription remoteDescription;
+ readonly attribute RTCSessionDescription remoteDescription;
readonly attribute DOMString signalingState;
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | Source/modules/mediastream/RTCSessionDescription.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698