Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test case crash. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html
diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html b/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html
index 06d84bb73efaee4c856cbde775693679717dc156..3b9938f8e653c264878d11cd9ffc33e97c3420ff 100644
--- a/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html
+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html
@@ -8,6 +8,7 @@
description("Tests RTCPeerConnection remoteDescription.");
var pc = null;
+var observation = null;
function requestFailed2()
{
@@ -38,8 +39,13 @@ function requestSucceeded1()
{
testPassed('requestSucceeded was called.');
- sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
- shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded2, requestFailed2);');
+ shouldBeTrue('pc.remoteDescription === sessionDescription');
+ observation = internals.observeGC(pc.remoteDescription);
+ asyncGC(function() {
+ shouldBeFalse('observation.wasCollected');
+ sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
+ shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded2, requestFailed2);');
+ });
}
pc = new webkitRTCPeerConnection(null, null);

Powered by Google App Engine
This is Rietveld 408576698