Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test case crash. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/mediastream/RTCPeerConnection-localDescription-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html b/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
index f5775886c4618a29cec1b657a2f089c15fe9efd1..9aabdf1981bd1f84c135cbc8377cce09866e7e48 100644
--- a/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html
@@ -8,6 +8,7 @@
description("Tests RTCPeerConnection localDescription.");
var pc = null;
+var observation = null;
function requestFailed2()
{
@@ -38,8 +39,13 @@ function requestSucceeded1()
{
testPassed('requestSucceeded was called.');
- sessionDescription = new RTCSessionDescription({type:"answer", sdp:"remote"});
- shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded2, requestFailed2);');
+ shouldBeTrue('pc.localDescription === sessionDescription');
+ observation = internals.observeGC(pc.localDescription);
+ asyncGC(function() {
+ shouldBeFalse('observation.wasCollected');
+ sessionDescription = new RTCSessionDescription({type:"answer", sdp:"remote"});
+ shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded2, requestFailed2);');
+ });
}
pc = new webkitRTCPeerConnection(null, null);
« no previous file with comments | « no previous file | LayoutTests/fast/mediastream/RTCPeerConnection-localDescription-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698