Issue 10103034: Web-app visual and string tweaks.

Issue 10103034: Web-app visual and string tweaks. (Closed)

Created:
8 years, 8 months ago by Jamie

Modified:
8 years, 8 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Web-app visual and string tweaks. * Implemented waiting class using a background image like error-state. * Make waiting text line up with Cancel buttons. * Make tool-bar spacing i18n- and hostname-safe. * Updated strings after reviewer feedback. * Fixed vertical position of host setup transitional text. BUG=None TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132601

Patch Set 1 #

Patch Set 2 : Fixed tabs. Added missing semi-colon. #

Total comments: 2

Patch Set 3 : Reworded start message. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -32 lines)			Patch
M	remoting/webapp/_locales/en/messages.json	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/webapp/main.css	View	1	2 chunks	+8 lines, -14 lines	0 comments	Download
M	remoting/webapp/main.html	View	1	4 chunks	+12 lines, -15 lines	0 comments	Download
M	remoting/webapp/toolbar.css	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

simonmorris

lgtm with optional suggestion http://codereview.chromium.org/10103034/diff/2001/remoting/webapp/_locales/en/messages.json File remoting/webapp/_locales/en/messages.json (right): http://codereview.chromium.org/10103034/diff/2001/remoting/webapp/_locales/en/messages.json#newcode222 remoting/webapp/_locales/en/messages.json:222: "message": "You must enable remote ...

8 years, 8 months ago (2012-04-17 16:52:33 UTC) #2

Jamie

8 years, 8 months ago (2012-04-17 17:57:57 UTC) #3

fyi

https://chromiumcodereview.appspot.com/10103034/diff/2001/remoting/webapp/_lo...
File remoting/webapp/_locales/en/messages.json (right):

https://chromiumcodereview.appspot.com/10103034/diff/2001/remoting/webapp/_lo...
remoting/webapp/_locales/en/messages.json:222: "message": "You must enable
remote connections if you want to allow Chromoting to access this computer.",
On 2012/04/17 16:52:34, simonmorris wrote:
> I think "want to use Chromoting to access" is clearer than "want to allow
> Chromoting to access".

Done.

Expand Messages | Collapse Messages