Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 10103027: Fixing tab order in open dialogs. (Closed)

Created:
8 years, 8 months ago by SeRya
Modified:
8 years, 8 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Fixing tab order in open dialogs. This CL prevents from loosing focus "between" elements. But focus still may be lost after last focusable item (it's a different issue not fixed here). BUG=chromium-os:29056 TEST=Open open and save dialogs. Check the tab order is following 1) File list (initialy focused in the open dialog), 2) File name box (initially focused in the save dialog, absends in the open dialog), 3) Open/Save button, 4) Cancel button. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/main.html View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
SeRya
8 years, 8 months ago (2012-04-17 08:04:20 UTC) #1
Vladislav Kaznacheev
lgtm
8 years, 8 months ago (2012-04-17 08:45:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10103027/1
8 years, 8 months ago (2012-04-17 09:16:41 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 10:43:14 UTC) #4
Can't apply patch for file chrome/browser/resources/file_manager/main.html.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/file_manager/main.html
Hunk #1 FAILED at 234.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/file_manager/main.html.rej

Powered by Google App Engine
This is Rietveld 408576698