views: Use NOTREACHED() where appropriate.

ui/views/examples/native_theme_button_example.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/examples/native_theme_button_example.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
@@ skipping 45 matching lines @@
   set_background(Background::CreateBackgroundPainter(
       false, painter_.get()));
 }
 
 ExampleNativeThemeButton::~ExampleNativeThemeButton() {
 }
 
 std::string ExampleNativeThemeButton::MessWithState() {
   const char* message = NULL;
   switch (GetThemePart()) {
-  case gfx::NativeTheme::kPushButton:
-    message = "Pressed! count:%d";
-    break;
-  case gfx::NativeTheme::kRadio:
-    is_checked_ = !is_checked_;
-    message = is_checked_ ? "Checked! count:%d" : "Unchecked! count:%d";
-    break;
-  case gfx::NativeTheme::kCheckbox:
-    if (is_indeterminate_) {
-      is_checked_ = false;
-      is_indeterminate_ = false;
-    } else if (!is_checked_) {
-      is_checked_ = true;
-    } else {
-      is_checked_ = false;
-      is_indeterminate_ = true;
-    }
-
-    message = is_checked_ ? "Checked! count:%d" :
-      is_indeterminate_ ? "Indeterminate! count:%d" : "Unchecked! count:%d";
-    break;
-  default:
-    DCHECK(false);
+    case gfx::NativeTheme::kPushButton:
+      message = "Pressed! count:%d";
+      break;
+    case gfx::NativeTheme::kRadio:
+      is_checked_ = !is_checked_;
+      message = is_checked_ ? "Checked! count:%d" : "Unchecked! count:%d";
+      break;
+    case gfx::NativeTheme::kCheckbox:
+      if (is_indeterminate_) {
+        is_checked_ = false;
+        is_indeterminate_ = false;
+      } else if (!is_checked_) {
+        is_checked_ = true;
+      } else {
+        is_checked_ = false;
+        is_indeterminate_ = true;
+      }
+      if (is_checked_)
+        message = "Checked! count:%d";
+      else if (is_indeterminate_)
+        message = "Indeterminate! count:%d";
+      else
+        message = "Unchecked! count:%d";
+      break;
+    default:
+      NOTREACHED();
   }
 
   return base::StringPrintf(message, ++count_);
 }
 
 void ExampleNativeThemeButton::OnSelectedIndexChanged(Combobox* combobox) {
   SchedulePaint();
 }
 
 gfx::NativeTheme::Part ExampleNativeThemeButton::GetThemePart() const {
   switch (cb_part_->selected_index()) {
     case 0:
       return gfx::NativeTheme::kPushButton;
     case 1:
       return gfx::NativeTheme::kRadio;
     case 2:
       return gfx::NativeTheme::kCheckbox;
     default:
-      DCHECK(false);
+      NOTREACHED();
   }
   return gfx::NativeTheme::kPushButton;
 }
 
 gfx::Rect ExampleNativeThemeButton::GetThemePaintRect() const {
   gfx::NativeTheme::ExtraParams extra;
   gfx::NativeTheme::State state = GetThemeState(&extra);
   gfx::Size size(gfx::NativeTheme::instance()->GetPartSize(GetThemePart(),
                                                            state,
                                                            extra));
@@ skipping 11 matching lines @@
     switch (state()) {
       case BS_DISABLED:
         return gfx::NativeTheme::kDisabled;
       case BS_NORMAL:
         return gfx::NativeTheme::kNormal;
       case BS_HOT:
         return gfx::NativeTheme::kHovered;
       case BS_PUSHED:
         return gfx::NativeTheme::kPressed;
       default:
-        DCHECK(false);
+        NOTREACHED();
     }
   }
 
   switch (selected) {
     case 0:
       return gfx::NativeTheme::kDisabled;
     case 1:
       return gfx::NativeTheme::kNormal;
     case 2:
       return gfx::NativeTheme::kHovered;
     case 3:
       return gfx::NativeTheme::kPressed;
     default:
-      DCHECK(false);
+      NOTREACHED();
   }
   return gfx::NativeTheme::kNormal;
 }
 
 void ExampleNativeThemeButton::GetExtraParams(
     gfx::NativeTheme::ExtraParams* params) const {
 
   params->button.checked = is_checked_;
   params->button.indeterminate = is_indeterminate_;
   params->button.is_default = false;
@@ skipping 83 matching lines @@
   layout->AddPaddingRow(0, 8);
 }
 
 void NativeThemeButtonExample::ButtonPressed(Button* sender,
                                              const Event& event) {
   PrintStatus(button_->MessWithState().c_str());
 }
 
 }  // namespace examples
 }  // namespace views