Issue 10103015: "View website" instead of "View in Web Store"

Issue 10103015: "View website" instead of "View in Web Store" (Closed)

Created:
8 years, 8 months ago by Evan Stade

Modified:
8 years, 7 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

"View website" instead of "View in Web Store" for extensions that have a homepage url BUG=105858 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134673

Patch Set 2 : update comment/var naming #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/resources/extensions/extension_list.js	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/extensions/extensions.html	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	chrome/common/extensions/extension_constants.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

I was/am on paternity leave (code review requests don't seem to trigger that auto-reply). I'm ...

8 years, 8 months ago (2012-04-27 23:21:00 UTC) #3

Mihai Parparita -not on Chrome

LGTM http://codereview.chromium.org/10103015/diff/1/chrome/browser/resources/extensions/extension_list.js File chrome/browser/resources/extensions/extension_list.js (right): http://codereview.chromium.org/10103015/diff/1/chrome/browser/resources/extensions/extension_list.js#newcode140 chrome/browser/resources/extensions/extension_list.js:140: // The 'View in Web Store' checkbox. Nit: ...

8 years, 7 months ago (2012-04-30 19:58:11 UTC) #4

Evan Stade

thanks. welcome back http://codereview.chromium.org/10103015/diff/1/chrome/browser/resources/extensions/extension_list.js File chrome/browser/resources/extensions/extension_list.js (right): http://codereview.chromium.org/10103015/diff/1/chrome/browser/resources/extensions/extension_list.js#newcode140 chrome/browser/resources/extensions/extension_list.js:140: // The 'View in Web Store' ...

8 years, 7 months ago (2012-04-30 23:15:38 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10103015/6002

8 years, 7 months ago (2012-04-30 23:23:36 UTC) #6

commit-bot: I haz the power

8 years, 7 months ago (2012-04-30 23:23:38 UTC) #7

Can't process patch for file chrome/common/extensions/extension_constants.cc.
File's status is None, patchset upload is incomplete.

Expand Messages | Collapse Messages