lib/compiler/implementation/ssa/tracer.dart - Issue 10098001: Refactor type propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/tracer.dart

Issue 10098001: Refactor type propagation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and add new test. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/tracer.dart

diff --git a/lib/compiler/implementation/ssa/tracer.dart b/lib/compiler/implementation/ssa/tracer.dart

index b3ebb4628830c1b8e77b601f489d88906ef1bacc..4e453141e73aa97cad12628710b1d17e9c1ffedd 100644

--- a/lib/compiler/implementation/ssa/tracer.dart

+++ b/lib/compiler/implementation/ssa/tracer.dart

@@ -165,7 +165,8 @@ class HInstructionStringifier implements HVisitor<String> {

String temporaryId(HInstruction instruction) {

String prefix;

- switch (instruction.type) {

+ HType type = instruction.propagatedType;

+ switch (type) {

case HType.MUTABLE_ARRAY: prefix = 'a'; break;

case HType.READABLE_ARRAY: prefix = 'roa'; break;

case HType.BOOLEAN: prefix = 'b'; break;

@@ -402,7 +403,7 @@ class HInstructionStringifier implements HVisitor<String> {

String visitTypeGuard(HTypeGuard node) {

String type;

- switch (node.type) {

+ switch (node.propagatedType) {

case HType.MUTABLE_ARRAY: type = "mutable_array"; break;

case HType.READABLE_ARRAY: type = "readable_array"; break;

case HType.BOOLEAN: type = "bool"; break;