lib/compiler/implementation/ssa/bailout.dart - Issue 10098001: Refactor type propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/bailout.dart

Issue 10098001: Refactor type propagation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and add new test. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/bailout.dart

diff --git a/lib/compiler/implementation/ssa/bailout.dart b/lib/compiler/implementation/ssa/bailout.dart

index 8b57edf1baee946a43b8ddb02bd9114e5154dd6c..1df10d158e8420518cef115a02a8e3d55c46cc23 100644

--- a/lib/compiler/implementation/ssa/bailout.dart

+++ b/lib/compiler/implementation/ssa/bailout.dart

@@ -276,7 +276,9 @@ class SsaTypeGuardBuilder extends HBaseVisitor implements OptimizationPhase {

}

bool shouldCaptureEnvironment(HInstruction instruction) {

- return instruction.type.isKnown() && !instruction.hasExpectedType();

+ HType propagatedType = instruction.propagatedType;

+ return propagatedType.isUseful()

+ && propagatedType != instruction.computeTypeFromInputTypes();

}

void insertCapturedEnvironments() {