Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: frog/tests/leg/src/TypeInferenceTest.dart

Issue 10098001: Refactor type propagation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix type for null and update tests. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/tests/leg/src/TypeInferenceTest.dart
diff --git a/frog/tests/leg/src/TypeInferenceTest.dart b/frog/tests/leg/src/TypeInferenceTest.dart
index 863b76d7f954079e1617fcae790cacc47e374c07..68c6c2b31cf30d3e3863f9addfc728ba1b2e2ce5 100644
--- a/frog/tests/leg/src/TypeInferenceTest.dart
+++ b/frog/tests/leg/src/TypeInferenceTest.dart
@@ -49,14 +49,10 @@ main(a) {
main() {
String generated = compile(TEST_ONE, 'sum');
- RegExp regexp = new RegExp("i = \\(?$anyIdentifier \\+ \\(1\\)\\)?");
- // TODO(ngeoffray): Do live range analysis to make this test pass.
- Expect.isFalse(regexp.hasMatch(generated));
- regexp = new RegExp("sum = \\(?$anyIdentifier \\+ $anyIdentifier\\)?");
- Expect.isTrue(regexp.hasMatch(generated));
+ // Some of TEST_ONE checks have been moved into separate tests.
kasperl 2012/04/16 09:09:43 I'm not sure this comment adds much value.
floitsch 2012/04/16 19:59:37 removed.
- regexp = const RegExp("typeof param0 !== 'number'");
+ Regexp regexp = new RegExp("sum = \\(?$anyIdentifier \\+ $anyIdentifier\\)?");
Expect.isTrue(regexp.hasMatch(generated));
regexp = const RegExp("typeof param1 !== 'number'");

Powered by Google App Engine
This is Rietveld 408576698