Refactor type propagation.

lib/compiler/implementation/ssa/types.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaTypePropagator extends HGraphVisitor implements OptimizationPhase {
 
   final Map<int, HInstruction> workmap;
   final List<int> worklist;
   final Compiler compiler;
   String get name() => 'type propagator';
 
   SsaTypePropagator(Compiler this.compiler)
       : workmap = new Map<int, HInstruction>(),
         worklist = new List<int>();
 
 
-  HType computeType(HInstruction instruction) => instruction.computeType();
+  HType computeType(HInstruction instruction) {
+    return instruction.computeTypeFromInputTypes();
+  }
 
   // Re-compute and update the type of the instruction. Returns
   // whether or not the type was changed.
   bool updateType(HInstruction instruction) {
-    if (instruction.type.isConflicting()) return false;
-    // Constants have the type they have. It can't be changed.
-    if (instruction.isConstant()) return false;
+    if (instruction.propagatedType.isConflicting()) return false;
 
-    HType oldType = instruction.type;
-    HType newType = computeType(instruction);
-    instruction.type = oldType.combine(newType);
-    return oldType !== instruction.type;
+    HType oldType = instruction.propagatedType;
+    HType newType = instruction.hasGuaranteedType()
+                    ? instruction.guaranteedType
+                    : computeType(instruction);
+    instruction.propagatedType = oldType.combine(newType);
+    return oldType !== instruction.propagatedType;
   }
 
   void visitGraph(HGraph graph) {
     visitDominatorTree(graph);
     processWorklist();
   }
 
   visitBasicBlock(HBasicBlock block) {
     if (block.isLoopHeader()) {
       block.forEachPhi((HPhi phi) {
-        // Set the initial type for the phi.
-        phi.type = phi.inputs[0].type;
+        // Set the initial type for the phi. In theory we would need to mark the
+        // type of all other incoming edges as "unitialized" and take this into
+        // account when doing the propagation inside the phis. Just setting
+        // the [propagatedType] is however easier.
+        phi.propagatedType = phi.inputs[0].propagatedType;
         addToWorkList(phi);
       });
     } else {
       block.forEachPhi((HPhi phi) {
-        if (updateType(phi)) addUsersAndInputsToWorklist(phi);
+        if (updateType(phi)) addDependentInstructionsToWorkList(phi);
       });
     }
 
     HInstruction instruction = block.first;
     while (instruction !== null) {
-      if (updateType(instruction)) addUsersAndInputsToWorklist(instruction);
+      if (updateType(instruction)) {
+        addDependentInstructionsToWorkList(instruction);
+      }
       instruction = instruction.next;
     }
   }
 
   void processWorklist() {
     while (!worklist.isEmpty()) {
       int id = worklist.removeLast();
       HInstruction instruction = workmap[id];
       assert(instruction !== null);
       workmap.remove(id);
-      if (updateType(instruction)) addUsersAndInputsToWorklist(instruction);
+      if (updateType(instruction)) {
+        addDependentInstructionsToWorkList(instruction);
+      }
     }
   }
 
-  void addUsersAndInputsToWorklist(HInstruction instruction) {
+  void addDependentInstructionsToWorkList(HInstruction instruction) {

[kasperl, 2012/04/16 09:09:43]

Add a comment that explains why you don't need to deal with the inputs here (and
maybe contrast that to the SpeculativeTypePropagator implementation of the same
method).

[floitsch, 2012/04/16 19:59:37]

Done.

     for (int i = 0, length = instruction.usedBy.length; i < length; i++) {
       addToWorkList(instruction.usedBy[i]);
-    }
-    for (int i = 0, length = instruction.inputs.length; i < length; i++) {
-      addToWorkList(instruction.inputs[i]);
-    }
+    }    
   }
 
   void addToWorkList(HInstruction instruction) {
     final int id = instruction.id;
     if (!workmap.containsKey(id)) {
       worklist.add(id);
       workmap[id] = instruction;
     }
   }
 }
 
 class SsaSpeculativeTypePropagator extends SsaTypePropagator {
   final String name = 'speculative type propagator';
   SsaSpeculativeTypePropagator(Compiler compiler) : super(compiler);
 
+  void addDependentInstructionsToWorkList(HInstruction instruction) {
+    for (int i = 0, length = instruction.usedBy.length; i < length; i++) {
+      addToWorkList(instruction.usedBy[i]);
+    }    
+    for (int i = 0, length = instruction.inputs.length; i < length; i++) {
+      addToWorkList(instruction.inputs[i]);
+    }
+  }
+
   HType computeDesiredType(HInstruction instruction) {
     HType desiredType = HType.UNKNOWN;
     for (final user in instruction.usedBy) {
       desiredType =
-          desiredType.combine(user.computeDesiredInputType(instruction));
+          desiredType.combine(user.computeDesiredTypeForInput(instruction));
       // No need to continue if two users disagree on the type.
       if (desiredType.isConflicting()) break;
     }
     return desiredType;
   }
 
   HType computeType(HInstruction instruction) {
     HType newType = super.computeType(instruction);
+    // [computeDesiredType] goes to all usedBys and lets them compute their
+    // desired type. By setting the [newType] here we give them more context to
+    // work with. 
+    instruction.propagatedType = newType;
     HType desiredType = computeDesiredType(instruction);
-    // If the desired type is conflicting just return the computed
-    // type.
+    // If the desired type is conflicting just return the computed type.
     if (desiredType.isConflicting()) return newType;
     return newType.combine(desiredType);
   }
 }