Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 10096015: Single URL Expires Were Not Being Deleted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/android/android_provider_backend_unittest.cc
===================================================================
--- chrome/browser/history/android/android_provider_backend_unittest.cc (revision 132411)
+++ chrome/browser/history/android/android_provider_backend_unittest.cc (working copy)
@@ -547,9 +547,6 @@
ASSERT_TRUE(delegate_.deleted_details());
EXPECT_FALSE(delegate_.modified_details());
EXPECT_EQ(1u, delegate_.deleted_details()->rows.size());
- EXPECT_EQ(1u, delegate_.deleted_details()->urls.size());
- EXPECT_TRUE(delegate_.deleted_details()->urls.end() !=
- delegate_.deleted_details()->urls.find(row1.url()));
EXPECT_EQ(row1.url(), delegate_.deleted_details()->rows[0].url());
EXPECT_EQ(row1.last_visit_time(),
delegate_.deleted_details()->rows[0].last_visit());
@@ -597,9 +594,6 @@
ASSERT_TRUE(delegate_.deleted_details());
EXPECT_FALSE(delegate_.modified_details());
EXPECT_EQ(1u, delegate_.deleted_details()->rows.size());
- EXPECT_EQ(1u, delegate_.deleted_details()->urls.size());
- EXPECT_TRUE(delegate_.deleted_details()->urls.end() !=
- delegate_.deleted_details()->urls.find(row2.url()));
EXPECT_EQ(row2.url(), delegate_.deleted_details()->rows[0].url());
EXPECT_EQ(row2.last_visit_time(),
delegate_.deleted_details()->rows[0].last_visit());
@@ -755,9 +749,6 @@
// Verify notifications, Update involves insert and delete URLS.
ASSERT_TRUE(delegate_.deleted_details());
EXPECT_EQ(1u, delegate_.deleted_details()->rows.size());
- EXPECT_EQ(1u, delegate_.deleted_details()->urls.size());
- EXPECT_TRUE(delegate_.deleted_details()->urls.end() !=
- delegate_.deleted_details()->urls.find(row1.url()));
EXPECT_EQ(row1.url(), delegate_.deleted_details()->rows[0].url());
EXPECT_EQ(row1.last_visit_time(),
delegate_.deleted_details()->rows[0].last_visit());
@@ -810,9 +801,6 @@
// Verify notifications, Update involves insert and delete URLS.
ASSERT_TRUE(delegate_.deleted_details());
EXPECT_EQ(1u, delegate_.deleted_details()->rows.size());
- EXPECT_EQ(1u, delegate_.deleted_details()->urls.size());
- EXPECT_TRUE(delegate_.deleted_details()->urls.end() !=
- delegate_.deleted_details()->urls.find(row2.url()));
EXPECT_EQ(row2.url(), delegate_.deleted_details()->rows[0].url());
EXPECT_EQ(row2.last_visit_time(),
delegate_.deleted_details()->rows[0].last_visit());
@@ -1496,9 +1484,6 @@
// Verify notification
ASSERT_TRUE(delegate_.deleted_details());
ASSERT_EQ(2u, delegate_.deleted_details()->rows.size());
- ASSERT_EQ(2u, delegate_.deleted_details()->urls.size());
- ASSERT_TRUE(delegate_.modified_details());
- ASSERT_EQ(1u, delegate_.modified_details()->changed_urls.size());
EXPECT_EQ(row1.url(),
delegate_.modified_details()->changed_urls[0].url());
EXPECT_EQ(Time::UnixEpoch(),
« no previous file with comments | « chrome/browser/history/android/android_provider_backend.cc ('k') | chrome/browser/history/expire_history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698